Features tries to access a non-existent array key, causing a notice:

WD php: Notice: Undefined index:  widget_active in content_features_rebuild() (line 161 of /sites/all/modules/features/includes/features.content.inc).
CommentFileSizeAuthor
#4 features-n985520-4.patch1.52 KBDamienMcKenna
#2 actions-985814-d6.patch658 bytesjoshuajabbour
#1 features-985520.patch802 bytesjoshuajabbour
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
Status: Active » Needs review
FileSize
features-985520.patch802 bytes
joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
FileSize
actions-985814-d6.patch658 bytes

wrong issue, ignore this patch...

beeradb’s picture

beeradb CreditAttribution: beeradb commented
Status: Needs review » Reviewed & tested by the community

This fixes the notices for me, is dead simple, and is best practice anyway. RTBC on #1.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Reviewed & tested by the community » Needs review
FileSize
features-n985520-4.patch1.52 KB

Here's another quick patch that fixes the same logic error in other places.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Reviewed & tested by the community

Looks good, and eliminates tons of unnecessary notices when running simpletests for me.

wojtha’s picture

wojtha CreditAttribution: wojtha commented

subscribing

ryan_courtnage’s picture

ryan_courtnage CreditAttribution: ryan_courtnage commented

Patch in #4 is good.

bleen’s picture

bleen CreditAttribution: bleen commented

bump / sub

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/features.git/commit/80db53f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Sknight17’s picture

Sknight17 CreditAttribution: Sknight17 commented

I'm noticing the patch in #4 hides the 'state' when using drush in the command line. The state will still show up in the UI. However, this patch makes it impossible for those that use 'drush fl' as apart of their workflow. Is anyone else experiencing the same issue?

bcmiller0’s picture

bcmiller0 CreditAttribution: bcmiller0 commented

we are hitting this case, but the actual data on hitting it shows $existing_instance[0]['widget_active']. Which seems like the patch avoids it but does a query update when it doesn't need to. as the widget_active is already set "1" but the existing_instance variable is an array when maybe shoudn't be.