Related Issue #413494: Support for comment edited message in the template

For a while, $comment->comment_edited was working perfectly in my Adv Forum template. But when I went to 6x1.4, it stopped working.
(I do have "use a template variable" enabled)

Comments

snufkin’s picture

snufkin CreditAttribution: snufkin commented

I'm sorry, I was too focused on getting the SA out that this bug slipped in, i'll try to fix it ASAP. It is safe to roll back to the version before the SA for the time being if you are the only person who has the administer comments permission in the system.

aharown07’s picture

aharown07 CreditAttribution: aharown07 commented

Thx. I was going to ask about roll back.
(Edit: Rollback successful... and we hv nobody w/admin besides user1 so the SA issue is not hot for us)

aharown07’s picture

aharown07 CreditAttribution: aharown07 commented

Any progress on this yet?

snufkin’s picture

snufkin CreditAttribution: snufkin commented

no

snufkin’s picture

snufkin CreditAttribution: snufkin commented

the reason why this broke is because I used a preprocess_comment - I wonder if i should just roll back to what it used to be, using preprocess_comment felt like the right way to go about this, since its a theming related change, but I am not familiar enough with the code of AF. I posted in the issue queue of that module to try to figure it out.

aharown07’s picture

aharown07 CreditAttribution: aharown07 commented

There's an alpha 4 now, but I haven't tested yet.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented
Title: Latest release breaks $comment->comment_edited in Advanced Forum 2.x Alpha3 » Latest release breaks $comment->comment_edited in Advanced Forum 2.x
Status: Active » Needs review

As per #413494: Support for comment edited message in the template I believe the integration between comment_edited (6.x-1.4) and advanced_forum (6.x-2.x-dev) is now fixed.

Marking as needs review so that snufkin can close this issue.

snufkin’s picture

snufkin CreditAttribution: snufkin commented
Status: Needs review » Fixed

yeah, that looks like is the correct fix for it. It would probably have been a better solution to keep using the $variables['comment_edited'] variable, but for now I am happy if it just works. Thanks for your work on this and supporting this module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aharown07’s picture

aharown07 CreditAttribution: aharown07 commented
Status: Closed (fixed) » Active

Did some testing today.
6x-1.3 works fine with the latest dev release of Adv Forum 2.
But 6x-1.4 does not, as far as I can tell. Maybe there is some new setting I missed somewhere?

Related: #413494: Support for comment edited message in the template

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented

I can confirm that this no longer looks like an AF problem (although we did have to make a change in the theme code).

It looks like the problem in comment_edited 6.x-1.4 has already been fixed in dev.

Details here: http://drupal.org/node/413494#comment-5918536