If a user tries to register a second time with the same email address Drupal currently tells them "The e-mail address greg@example.com is already taken." Which isn't terribly helpful.

This patch simply changes it to say:

"The e-mail address greg@example.com is already registered. Have you forgotten your password?"

This is consistent with the message sent when a user sends an incorrect password.

CommentFileSizeAuthor
#4 re_register_1.patch1.66 KBwebchick
#2 re_register_0.patch1.6 KBgreggles
re_register.patch1014 bytesgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobRoy’s picture

RobRoy CreditAttribution: RobRoy commented
Status: Needs review » Needs work

Good idea. But we shouldn't pass that translated link to t() again as any translated elements in that will get re-translated. I'd either move it after the end of the t() call or include it as a %password-link for example.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs work » Needs review
FileSize
re_register_0.patch1.6 KB

thanks RobRoy - for posterity, webchick had the same advice.

Here is an updated patch that includes that advice AND (as a bonus) fixes a situation earlier in the module where we had two calls to t() on the same line. Using this patch translators will get more context about what they are translating.

RobRoy’s picture

RobRoy CreditAttribution: RobRoy commented

Good enough for me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community
FileSize
re_register_1.patch1.66 KB

Looks good! This patch is exactly the same, but removes an extra space between the . and the <a href because I'm just picky that way. ;)

Marking RTBC since a few of us have looked at it now.

Dries’s picture

Dries CreditAttribution: Dries commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

This is not a critical issue, folks!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Sorry, Dries. The critical status was my fault. I was just following the protocol of the other string freeze issues to get them in before the RC (as Webchick laid out in her mail on the subject to the devel list).

Either way - thanks for committing it :)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)