Drupal 7 port [#991356]

Comment	File	Size	Author
#7	css_emimage.module.patch	2.46 KB	vitok-dupe

Comment #1

jcarnett CreditAttribution: jcarnett commented 4 January 2011 at 18:31

Version:	6.x-2.x-dev	» 7.x-1.x-dev
Status:	Active	» Needs review

The Drupal 7 version has been committed to CVS and should appear as a downloadable package soon. I'd appreciate any help testing it, and if all goes well I'll mark it as a final release when Drupal 7 is final.

Log in or register to post comments

Comment #2

vitok-dupe CreditAttribution: vitok-dupe commented 5 January 2011 at 17:37

Ok. I'd love to test it!

Log in or register to post comments

Comment #3

jcarnett CreditAttribution: jcarnett commented 9 January 2011 at 04:03

Status:

Needs review

» Fixed

The D7 port seems to be working well for me so I went ahead and made the official release. Let me know if you run into any issues.

Log in or register to post comments

Comment #4

vitok-dupe CreditAttribution: vitok-dupe commented 9 January 2011 at 11:17

Seems what work well. I can't find any issues. Thanks for your work, now i just waiting MHTML for IE. :)

Log in or register to post comments

Comment #5

23 January 2011 at 11:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #6

vitok-dupe CreditAttribution: vitok-dupe commented 3 February 2011 at 10:12

Status:

Closed (fixed)

» Needs work

I'm may by wrong, but I think what split Embedded images to other css file it's not good idea for drupal 7 aggregation method, cause now it's generate to many css files, by default we have 4 css file for anonymous role, and after CSS Embedded Images aggregation we have 7 css files. I think for D7 branch it's would be a good idea to have Embedded Images in the bottom of the original file, not in the new.

Log in or register to post comments

Comment #7

vitok-dupe CreditAttribution: vitok-dupe commented 3 February 2011 at 13:27

Status:

Needs work

» Needs review

File	Size
css_emimage.module.patch	2.46 KB

Something like this:

Log in or register to post comments

Comment #8

threading_signals CreditAttribution: threading_signals commented 8 February 2011 at 22:21

I deleted my sites/*/files js, and css files, and used the patch. It didn't seem to have any adverse affects from what I could tell.

Log in or register to post comments

Comment #9

jcarnett CreditAttribution: jcarnett commented 8 February 2011 at 22:38

Status:

Needs review

» Closed (fixed)

This is by design in the 6.x-2.x and 7.x-1.x versions, but I'm willing to add an option to disable this feature (i.e. fall back to the 6.x-1.x behavior). I've created a separate issue for the request: #1055544: Option to always inline image data. Please post any other comments there.