Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The handling between setting a field or using the auto-discovery is a little wonky.
I tried using the node changed/created values, various from/to combinations, and all day events, and got very strange results.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | fullcalendar-992812-4.patch | 10.16 KB | tim.plunkett |
| #3 | fullcalendar-992812-3.patch | 9.22 KB | tim.plunkett |
| #1 | fullcalendar-992812-1.patch | 10.71 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThis is a rewrite of that code, which is less repetitious and slightly faster. It also will hopefully allow for an easier upgrade to D7.
Comment #2
geerlingguy CreditAttribution: geerlingguy commentedReviewing now... at least a bit. If this is committed, we'll need to make a note in the upgrade notice/CVS commit message that CSS class names have changed.
Initial read-through looks good, but as discussed in CVS, it would be great if another version of the patch could be made that didn't have the CSS changes included. Finally, there is a bit of code cleanup included in the above patch that might be best to do more comprehensively in another issue.
Comment #3
tim.plunkettWith extraneous changes removed.
Comment #4
tim.plunkettAlright, here's a new version that mirrors the direction the D7 port is taking.
It uses the new
date_field_all_day()from #447728: "All day" nodes are not detected as such because of the granularity of the Date field, which means it requires date-6.x-2.x-dev until date-6.x-2.7 is released.Comment #5
tim.plunkettComment #6
geerlingguy CreditAttribution: geerlingguy commentedPatch works perfectly, makes code shorter, is nice. I got a couple of 'Hunk Failed' messages, but that's probably due to the fact that my current Fullcalendar module installation has two other patches already applied, confusing
patch- I manually applied the two failed hunks.(for reference, I have these two patches applied: #906112: handle drag and drop: creating events, rescheduling events (#47) and #980180: Extra trailing comma breaks Fullcalendar in IE 7 & IE 6 [BROKEN AGAIN] (#3)).
I should really just move to -dev. I think, once this patch is committed, I will. Of course, this module's about ready for a final release! :-)
Comment #7
tim.plunketthttp://drupal.org/cvs?commit=464734