The upgrade path D5->D6 is potentially broken, as described below:

During update 6001 the function _filefield_update_6001_move_operation is executed repeatedly within multiple client-server roundtrips. It is supposed to update rows in batches of 50 while keeping the progress meter running. It is possible for this process to get stuck if the query condition "vid > %d" for the while loop (filefield.install:310) results in zero rows being returned. In this case the line $context['sandbox']['progress']++; at filefield.install:327 is never executed, and the progress meter never reaches completion. The user sees something like "Remaining 34 of 34...", the web server being hit with many requests, high CPU usage and the same database query being executed over and over again (because of the roundtrip the script is never aborted due to max execution time limit, so the server is pounded as long as the browser remains open).

Comments

Status:Active» Needs review
StatusFileSize
new899 bytes

At first I couldn't quite figure out in the logic how this would be possible. If the query condition returned 0, you should have finished processing all the nodes and 'progress' would equal 'max', letting the loop exit. However, I found that the update might accidentally skip some content due to an error in our query. This patch changes "nid" to "vid" in our query, ensuring that no nodes are skipped, and hopefully that means that the loop will always be able to exit.

If you could try this patch out on your upgrade and run it again, that would be tremendously helpful. It's rather difficult to reproduce problems like this.

The patch doesn't help. I captured the content of $context['sandbox'] before and after the while loop in the stuck state. As you can see, even though the query returns no rows, progress is not equal max and not being incremented due to the loop not being executed at all.

    [db_info] => Array
        (
            [table] => content_field_anlage_7_f_plan_efre_anga
            [columns] => Array
                (
                    [fid] => Array
                        (
                            [type] => int
                            [not null] =>
                            [views] => 1
                            [column] => field_anlage_7_f_plan_efre_anga_fid
                        )  
                    [list] => Array
                        (
                            [type] => int
                            [size] => tiny
                            [not null] =>
                            [views] => 1
                            [column] => field_anlage_7_f_plan_efre_anga_list
                        )  
                    [data] => Array
                        (
                            [type] => text
                            [serialize] => 1
                            [views] => 1
                            [column] => field_anlage_7_f_plan_efre_anga_data
                        )  
                )
        )
    [table] => content_field_anlage_7_f_plan_efre_anga
    [col_data] => field_anlage_7_f_plan_efre_anga_data
    [col_desc] =>
    [max] => 14240
    [progress] => 13341
    [current_node] => 20895

I suppose your method of counting is broken because vid alone is non-unique in the table that is being processed:

mysql> select count(*) from content_field_anlage_7_f_plan_efre_anga;
+----------+
| count(*) |
+----------+
|    14240 |
+----------+
1 row in set (0.00 sec)
mysql> select count(distinct vid) from content_field_anlage_7_f_plan_efre_anga;
+---------------------+
| count(distinct vid) |
+---------------------+
|                6521 |
+---------------------+
1 row in set (0.02 sec)
mysql> describe content_field_anlage_7_f_plan_efre_anga;
+--------------------------------------+------------------+------+-----+---------+-------+
| Field                                | Type             | Null | Key | Default | Extra |
+--------------------------------------+------------------+------+-----+---------+-------+
| vid                                  | int(10) unsigned | NO   | PRI | 0       |       |
| delta                                | int(10) unsigned | NO   | PRI | 0       |       |
| nid                                  | int(10) unsigned | NO   | MUL | 0       |       |
| field_anlage_7_f_plan_efre_anga_fid  | int(11)          | YES  |     | NULL    |       |
| field_anlage_7_f_plan_efre_anga_list | tinyint(4)       | YES  |     | NULL    |       |
| field_anlage_7_f_plan_efre_anga_data | text             | YES  |     | NULL    |       |
+--------------------------------------+------------------+------+-----+---------+-------+
6 rows in set (0.00 sec)

StatusFileSize
new2.88 KB

I suppose your method of counting is broken because vid alone is non-unique in the table that is being processed:

VID doesn't have to be unique, since you can upload multiple files to a single revision of a node. The loop is for every individual file, not each revision.

I think another alternative here is the situation where a revision has multiple files that end up getting lost because the 50 item cap has been reached before the node is entirely processed.

For example, let's say you have a single multi-value field that has 10 images uploaded into it. But 48 files have been processed from other nodes during the update, the update will only convert 2 of the 10 files before hitting the 50 item limit. Then on the next request the update will start with the next node, because it thinks the previous node was fully processed.

This patch makes it so that our update starts every time with last node that was already processed and checks to make sure that all that node's items are pulled in before starting on the next node. Note I haven't been able to test this upgrade, so again it would a huge help if you could give it a try.

I confirm that this new patch solves the infinite loop problem. Hopefully, it also doesn't miss any row that needs to be upgraded.

Status:Needs review» Fixed

Sweet thanks! I've committed this patch because the logic makes sense after my re-reading several times. Please continue posting updates as you check your updated installation.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.