The patch in #113611-82: Forum count incorrect when using access control modules is perfect (at least as far as being able to be applied), yet the testbot refuses to apply it. It's still the same as the one in #56, June 1, and a number of people have tried and failed...

Please look into this.

Comments

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

It took a very long time to complete, but as before the testbot failed to apply the patch.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Priority: Normal » Major

Please?

Do we have to rename the patch file to end with -D6 to keep it from the testbot? I don't understand this. The testbot knows full well that it's a D6 patch because it's a D6 issue, and according to the log messages it tries to apply it to D6. Should it work or not?

If we know that it doesn't work, then why does the testbot even try (and reset the issue to NW)?

The linked issue has been blocked for half a year now because of this!

Offlein’s picture

Offlein CreditAttribution: Offlein commented

Yeah, what's the story here? Our patch is a beautiful angel .. and as though it should be treated!

stella’s picture

stella CreditAttribution: stella commented
Status: Active » Closed (duplicate)

duplicate of #961172: All D6 Core patches are failing

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Project: Test driven development infrastructure » Project Issue File Review
Status: Closed (duplicate) » Active

Moving this where it's more obvious so we can make sure it gets fixed.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

PIFR thinks this is a contrib patch or something. Note that the patch is being applied in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules instead of in /var/lib/drupaltestbot/sites/default/files/checkout/checkout (the Drupal root) :

[23:24:49] Command [patch -p0 -i /var/lib/drupaltestbot/sites/default/files/review/drupal-forum-dups.113611.82_0.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Status [1]
 Output: [patching file modules/forum/forum.module
Hunk #1 FAILED at 495.
Hunk #2 FAILED at 546.
Hunk #3 FAILED at 575.
3 out of 3 hunks FAILED -- saving rejects to file modules/forum/forum.module.rej].
rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Active » Closed (duplicate)

Pushing this back to a dup #961172: All D6 Core patches are failing. I've tested the instance in this patch and it's resolved by the fix there. Please follow deployment over there. Hopefully we can get it in within a few days.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

I would appreciate if any interested parties would test the current code in the staging environment.

Information about how to test is at http://groups.drupal.org/node/137189