"Main menu" heading displayed for primary links? [#995986]

Is there any particular reason the 'Main menu' heading is added to the primary links display (in page.tpl.php)? I can't think of one theme I've ever created where I explicitly wanted to display a heading anywhere around the primary links, as they are pretty obviously the primary links/navigation... :-/

(And the same goes for secondary links...).

Comment	File	Size	Author
#5	menu-update-995986-5.patch	2.69 KB	ishmael-sanchez
#3	boron_995986.patch	1.36 KB	levelos

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

geerlingguy CreditAttribution: geerlingguy commented 15 December 2010 at 15:06

If anything, I think this heading should have the .element-invisible class applied.

Comment #2

Scott J CreditAttribution: Scott J commented 2 January 2011 at 22:24

I think that headings are there to help sight-impaired readers find their way, as it may not be pretty obvious to them where the primary links are. But yes, they can be marked as invisible. Other themes such as Garland are doing it that way.

http://drupal.org/node/364219
http://drupal.org/update/theme/6/7#element-hidden
http://drupal.org/update/theme/6/7#theme-links-param
http://drupal.org/node/464472

Comment #3

levelos CreditAttribution: levelos commented 6 January 2011 at 21:46

Status:

Active

» Needs review

File	Size
boron_995986.patch	1.36 KB

Here's a patch to fix the problem.

Comment #4

geerlingguy CreditAttribution: geerlingguy commented 10 February 2011 at 18:42

Status:

Needs review

» Reviewed & tested by the community

Please commit - this fixes some layout errors in the MM theme, too... #1057752: Fix various layout issues (from fresh Drupal install).

Comment #5

ishmael-sanchez CreditAttribution: ishmael-sanchez commented 1 April 2011 at 03:16

Status:

Reviewed & tested by the community

» Needs review

File	Size
menu-update-995986-5.patch	2.69 KB

I have attached an updated patch that hides the menu headers and is a bit easier to read and the patch also includes a fix to put the menu links inline.

Comment #6

danlinn CreditAttribution: danlinn commented 4 May 2011 at 21:10

Status:

Needs review

» Patch (to be ported)

Hello,

I agree that this link should be hidden by default. However, having inline links is a styling choice. I'll apply the first patch.

Thanks,
Dan

Comment #7

geerlingguy CreditAttribution: geerlingguy commented 5 May 2011 at 05:09

Woot! More progress... I was beginning to worry Boron dev was lying dormant, but I've been noticing a bunch of FB ads recently, and now a new 1.0 release! Will this patch be applied soon? I'd still like to clean out a little bit of the cruft from my mm contrib theme, and release a 1.0 of that as well...