When using this module, the HTML it generates and adds to the page (used by Firebug to fill its panel) contains multiple xhtml errors. Most of these can be easily fixed (font as styled span, etc).

My first bug report/contribution to drupal modules, so sorry if it's not quite right, hope it'll help anyway.

Note on this patch:
1) It hides the 'PHP Execution' iframe if the user doesn't have the right to it: this might get tricky in some situation I do not know of, but at least it didn't crash Firebug for me.
2) The HTML still won't validate if you have the rights to PHP Execution, but that requires a much bigger change as iframes are not available in strict XHTML.
3) It doesn't fix the issue entirely for the reason(s) exposed above, but helps me check whether my XHTML validates as I don't use the PHP Execution feature. Hopefully, it could help others similarly.

CommentFileSizeAuthor
drupalforfirebug-htmlfixes.patch3.46 KBTelem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frob’s picture

Status: Needs review » Closed (works as designed)

The patch doesn't apply correctly.

This isn't a high priority and I am only doing maintains fixes to the 6.x branch at this point, so I am closing this issue. If you re-roll this patch and it works then I will apply it and post it.