There is some duplicate text in an error message that can occur during the install process:

In order for Drupal to work, and to continue with the installation process, you must resolve all issues reported below. For more help with configuring your database server, see the Installation and upgrading handbook. If you are unsure what any of this means you should probably contact your hosting provider.

Failed to connect to your MySQL database server. MySQL reports the following message: SQLSTATE[28000] [1045] Access denied for user 'rooot'@'localhost' (using password: NO).

  • Are you sure you have the correct username and password?
  • Are you sure that you have typed the correct database hostname?
  • Are you sure that the database server is running?

For more help, see the Installation and upgrading handbook. If you are unsure what these terms mean you should probably contact your hosting provider.

This patch removes the second instance of the sentence "For more help [...] your hosting provider."

CommentFileSizeAuthor
#21 db_missing_helptext-6.patch1.48 KBDavid_Rothstein
#20 db_missing_helptext-5.patch1.54 KBDavid_Rothstein
#18 db_missing_helptext-4.patch1.54 KBreglogge
#18 db_missing_helptext-4.png93.88 KBreglogge
#15 db_missing_helptext_3.png93.95 KBreglogge
#14 db_missing_helptext-3.patch1.54 KBreglogge
#9 db_missing_helptext-2.patch1.48 KBreglogge
#9 db_missing_helptext-2.png68.84 KBreglogge
#6 db_missing_helptext.patch1.5 KBtstoeckler
#5 db_missing_helptext.png78 KBreglogge
#5 db_missing_helptext.patch1.53 KBreglogge
#3 db_missing_helptext.png74.91 KBreglogge
#3 db_missing_helptext.patch1.53 KBreglogge
#1 seven_install_error.png76.73 KBmarcvangend
install_duplicated_help.patch1.54 KBmarcvangend

Comments

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented
StatusFileSize
new seven_install_error.png76.73 KB

Yoroy asked me to post a screenshot of the error message, so here it is.
PS. we should keep in mind that this is obviously not the only possible error.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Hey thanks, subscribing for now…

reglogge’s picture

reglogge CreditAttribution: reglogge commented
StatusFileSize
new db_missing_helptext.patch1.53 KB
new db_missing_helptext.png74.91 KB

Rerolled the patch with three changes:

- patched against current HEAD
- entirely removed the paragraph after the list of suggestions (entire paragraph was duplicate)
- added one item to the list asking the user to check whether the database exists at all or whether he misspelled the database name (we do the same for db-username and password). This is a quite common hiccup during install, so I think it belongs in there.

Screenshot attached.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

If it's

have typed the correct database name

and

have typed the correct database hostname

it should also be

have typed the correct username and password

I would actually suggest replacing typed with entered, but in any case all three should be consistent.

reglogge’s picture

reglogge CreditAttribution: reglogge commented
StatusFileSize
new db_missing_helptext.patch1.53 KB
new db_missing_helptext.png78 KB

Thanks for noting this.

Reroll attached.

Had to change the first line to prevent line wrapping.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
StatusFileSize
new db_missing_helptext.patch1.5 KB

One other thing concerning consistency:
The last three sentences start with Are you sure..., while the first one doesn't. This should be consistent.
My vote is to kill the Are you sure..., because it looks really weird to have four lines below each other that have the same three words.
Therefore my proposal is:

  • Does the database exist and have you entered the correct database name?
  • Have you entered the correct username and password?
  • Have you entered the correct database hostname?
  • Is the database server running?

Manually edited the patchfile with the above text.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

I just realized that there's a nasty thing called string freeze, so this probably sends us back to the initial patch. Well, not for me to decide anyways...

Status: Needs review » Needs work

The last submitted patch, db_missing_helptext.patch, failed testing.

reglogge’s picture

reglogge CreditAttribution: reglogge commented
StatusFileSize
new db_missing_helptext-2.png68.84 KB
new db_missing_helptext-2.patch1.48 KB

rerolled with text from #6, attached screenshot.

reglogge’s picture

reglogge CreditAttribution: reglogge commented
Status: Needs work » Needs review

come on, bot!

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented

Great to see that this issue is picked up again, I must admit that I forgot about it. I just noticed that there is another duplication that is not yet solved by this patch. The black-on-white title above the error massages is pretty much the same as the first sentence in the orange box. I'm not really sure which one should be removed, we probably have too look at the code to see where each sentence is created and why.

retester2010’s picture

retester2010 CreditAttribution: retester2010 commented

#9: db_missing_helptext-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, db_missing_helptext-2.patch, failed testing.

reglogge’s picture

reglogge CreditAttribution: reglogge commented
Status: Needs work » Needs review
StatusFileSize
new db_missing_helptext-3.patch1.54 KB

re #11: The black-and-white title isn't in Drupal core anymore, so I've rerolled the patch from #9 against the current HEAD. Patch attached.

reglogge’s picture

reglogge CreditAttribution: reglogge commented
StatusFileSize
new db_missing_helptext_3.png93.95 KB

added a screenshot...

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Reviewed & tested by the community

Thanks for the reroll, applied the patch, it works. This issue is about removing the duplicate text only, and for that it is RTBC.

Before: http://skitch.com/yoroy/dp9kc/dberror-before
After: http://skitch.com/yoroy/dp9mb/dberror-after

#639368: Contrast between error and link colour causes death to eyeballs Should take care of actual readability of the message! :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: avpaderno commented

If we are going to change the text, then we should re-order the suggestions. Is the database server running? should be the first one.

  1. Is the database server running?
  2. Does the database exist and have you entered the correct database name?
  3. Have you entered the correct database hostname?
  4. Have you entered the correct username and password?
reglogge’s picture

reglogge CreditAttribution: reglogge commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new db_missing_helptext-4.png93.88 KB
new db_missing_helptext-4.patch1.54 KB

rerolled the patch according to #17s suggestion, which makes sense...

I also switched around the last two entries suggested by #17 since for entering the hostname, the user would have to open the fieldset "Advanced options" first. Also I think, the three other possible errors are way more common than a false hostname which is "localhost" most of the time anyway.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: avpaderno commented
Status: Needs review » Reviewed & tested by the community

The order of the suggestions is much better, now. I agree that a wrong username (or password) is an error more common than entering a wrong hostname, as in most cases the database server runs in the same domain where Drupal is installed.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
StatusFileSize
new db_missing_helptext-5.patch1.54 KB

Looks great to me too. There is a missing comma after "Does the database exist", though. I fixed it in the attached.

It occurs to me that the intro paragraph beginning with "In order for Drupal to work" is a little oddly-worded also, but we can address that in a separate issue.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
StatusFileSize
new db_missing_helptext-6.patch1.48 KB

Er, wait a second. Both of the last two patches introduced indentation errors. Here it is without those.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

I created #863594: Strange first paragraph in the installer database error message for the issues with the intro paragraph.

dries’s picture

dries CreditAttribution: dries commented
Status: Reviewed & tested by the community » Fixed

Looks good. Committed to CVS HEAD. Dankuwel.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented

Wow, just returned from a short holiday, and suddenly this is committed :-) Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.