Mailhandler comment created and changed date and time stored incorrectly

Where Sergey Demidenko ( http://drupal.org/user/573574 ) already nicely wrote:

If you are importing a set of emails from an MBOX and some emails are added into drupal in the form of reply comments, these comments dates will be set to the date of import, not the date the email was sent.

In mailhandler.module mailhandler_comment_submit function. I set $node->created and $node->changed to a timestamp generated from $node->date (which is set to the date of the email).

Insert this code:

...
// Get $node->created from $node->date
$string = $node->date;
$string_explode = explode(' ', $string);
$string_date = $string_explode[0];
$string_time = $string_explode[1];
$string_date_explode = explode('-', $string_date);
$string_time_explode = explode(':', $string_time);
$timestamp = mktime($string_time_explode[0],$string_time_explode[1],$string_time_explode[2],$string_date_explode[1], $string_date_explode[2], $string_date_explode[0]);
$node->created = $timestamp;
$node->changed = $timestamp;
...

A very nice investigation already, however not taken into account the original line that is wrong where $node->created gets a date format in and not a unix timestamp.

Also the full date issue need to look into since sometimes there is no udate in the emailbody but no fallback scenario is created. Als othe timezone of original email is not take into account. This has to be crossreleated to the timezone of the server set datetime.

There is issue http://drupal.org/node/47170 describing the situation is some detail. However this issue is two separate issues in one ticket :(. I will resolve the second one and then this issue is a duplicate.

To make sure Sergey's nice effort does not get lost , attached his patch here, (even though the patch is not fully correct)

I cannot confirm(yet), only that I use "Official" Drupal API calls in the preliminary fix. It would be great if you could test that.

BTW there is a handy module called Krumo http://drupal.org/project/krumo where you can look at the LIVE values

FYI currently walking through all the Mailhandler issue from bottom up to see if I can fix "low hanging fruit" issue types so the issue list is less cluttered and we can focus on having a even better mailhandler module by fixing the real open defects.

If you already have incorrect node_comment_statistics running this to fix the node comment_http://drupal.org/node/137458#comment-3832938

But testing is first best done on a clean database.

As before we will use only official drupal API calls, thus if we adhere to the API all should be OK. if not OK node_comment_statistics could also have a defect ;)

Remark

Going through the full mailhandler.module code I came across node_object_prepare. and there if not isset node created the current time is set. So if we would not set the created later on the current server time will be set. sometine to keep in mind

The Drupal API reference

...
<?php
function node_object_prepare(&$node) {
  // Set up default values, if required.
  if (!isset($node->created)) {
    $node->created = time();
  }
  if (!isset($node->date)) {
    $node->date = format_date($node->created, 'custom', 'Y-m-d H:i:s O');
  }
...

Implementing comment_presave and comment_nodeapi do not seem to work :( , ongoing investigation

Investigating and debug showed, D6.19 and 6.20 still do not have the comment_presave hook implemented :(

The current Drupal 6.x-dev I've cloned from GIT does!

   module_invoke_all('comment_presave', $comment);
   module_invoke_all('entity_presave', $comment, 'comment');

However I found a way for node_save, and for datetimestamps it does work already. Before a patch can be released the whole issues must be solved, inclusive the TimeZone Timestamp issues. Still working to get all fixed before NewYear 2011

I've have to setup a local server for easier testing and debugging first...

Have a local working version and also a codechange to solve the Mailhandler to listhandler messages not sorted an threaded correctly if the message ID was not in the order of mail arrival date. Will make patches and submit here for review. Need to cleanup code to Drupal standards and remove some debugging code first.

Patch for 1.x included, plz. test and integrate if OK

Changed status, It would be great if it would be integrated into the main dev version. and make a new patch if needed for the 6.x-1.x-dev version of 14-march-2011 with all improvements of ilo

Thanks for test, will make a new patch but confused against which version of 6.x-v1.x.
It would be great if anyone could guide me there.