Update to 5.x
hickory - November 28, 2006 - 17:45
| Project: | Community Tags |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Description
Here's a patch that updates the module for 5.0. There are some extra bits in the patch because of whitespace, but I couldn't get it any closer.
I also removed the 'tag this item' page and the corresponding menu item, because it doesn't seem very useful, and made the tag form appear on every node. There should really be a configuration setting for whether the form should appear only on single item pages or everywhere.
| Attachment | Size |
|---|---|
| community_tags_5.patch | 19.54 KB |
#1
Here's the .info file.
#2
Cool, thanks for this!
a) I want to keep the dynamic menu item; this is necessary if I want use custom theming and have the form on a separate page. Feel free to make this a configurable option, though.
b) The description in the .info file isn't descriptive enough. I'd prefer to copy/paste the one in the old description. You'll probably need to put in in double quotes.
c) +1 for getting rid of crappy extra whitespace. :)
#3
A minimal update patch to 5.x is attached.
Hopefully free of opinion and extra whitespace.
#4
hi...i have done everything for make it working with drupal5: patched, activated the module, set settings and define user-access. when i create content, i see a row with 'community tags' and those tags are shown at the created content (node). but there's no way to tag the created content...
#5
Attached is a modified .info file that is a bit more descriptive as requested by webchick here.
toul said, "but there's no way to tag the created content..."
I have the same problem, and have isolated it to an access control check.
The $node->community_tags_form variable is FALSE even though I checked the all of the checkboxes for the category vocab to be implemented with all of the content-types (i.e. at example.com/admin/content/taxonomy/edit/vocabulary/1)
Here is the snippet of code in question:
$node->community_tags_form = variable_get('community_tags_'. $node->type, FALSE);When I change this line from:
'access' => (user_access('tag content') && $node->community_tags_form),to
'access' => (user_access('tag content')),Then I see the "edit this" option on the nodes, and am able to add tags... but this isn't a long-term solution. Any thoughts as to what else needs to change?
#6
My previous comment was in reference to samo's community_tags.patch. It appears that the hook_form_alter is not working properly, and the option to "Provide option to enable Community Tags per node type" does not show up properly.
However, with regards to hickory's original community_tags_5.patch does indeed functionally work.
However, the exclusion of the dynamic menu item "Tag It!" is preventing it from being committed.
I agree with Webchick that hiding the text field is important. I'm going to see if I can do this via jQuery instead of doing it via a separate page.
And I prefer Hickory's UI for tagging without extra the extra latency of a page load.
So I have the 5.x version working now, and am going to play around with it some more.
#7
Not that I know what I'm doing but for 5.x shouldn't:
$output .= form_render($form);Be replaced by this:
$output .= drupal_render($form);In any case, it'd be great if this module could be upgraded to 5.x.
#8
subscribing thanks everyone!
#9
subscribing.
It would be great to see a new version released! Thanks
#10
It looks like Steven's placed a 5.x compatible version in the HEAD branch. No release for it yet, but probably could use some reviews.
#11
subscribing
Sounds like somethig I need for version 2 of an in progress project.
#12
The module has already been updated to 5.