Closed (fixed)
Project:
Forward
Version:
6.x-1.21
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Dec 2010 at 03:54 UTC
Updated:
10 Mar 2012 at 19:50 UTC
Jump to comment: Most recent file
The following two lines appear to be unused.
global $base_url;
$host=parse_url($base_url);
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1002378.patch | 477 bytes | jzacsh |
Comments
Comment #1
jzacsh commentedlol, I also just noticed this.
Comment #2
jzacsh commentedPatch #1 above, just needs to be reviewed.
Comment #3
john.oltman commentedAppears to still be an issue in 6.x-1.21 and in a couple other functions as well. I can take it from here unless you want to expand the patch yourself.
Comment #4
jzacsh commented@john.oltman Are you sure the above patch was ever even committed?
Comment #5
john.oltman commentedNo, it wasn't committed, that is why I am asking - do you want to expand your patch from #1 to cover all the places there is unused similar code and post a revised patch here, or do you want me to take your patch from #1 and expand it myself. I am happy to take the baton from you at this point and commit an expanded patch within the next week. But I am asking in case you wanted to figure this out on your own - didn't want to step on your toes if you are nice enough to help out. Either way.
Comment #6
jzacsh commentedAh, understood. Feel free to expand the patch, I won't be looking at this stuff for a long time anyway :)
Comment #7
john.oltman commentedCommitted and will be in the next nightly build.
Comment #8
john.oltman commented