Hello.
It is very usefull to have hooks on linkedin account saves/deletes.
Please review patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | linkedin_hooks.patch | 1.69 KB | bellesmanieres |
| linkedin_hooks.patch | 1.48 KB | igor.ro |
Hello.
It is very usefull to have hooks on linkedin account saves/deletes.
Please review patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | linkedin_hooks.patch | 1.69 KB | bellesmanieres |
| linkedin_hooks.patch | 1.48 KB | igor.ro |
Comments
Comment #1
greg.harveySeems good to me. I'd +1 this.
Comment #2
bellesmanieres commentedGood idea, might be useful. Made a few changes to the original patch though :
- renamed to "linkedin_account_inserted" and "linkedin_account_deleted" (I'm always afraid of name collision with functions ending in "delete/save" + it occurs after the save/delete operation has been made, so sounds more logical)
- "linkedin_account_inserted" called only at access token save time : request token is only a temporary token, that is called before users have authorized our instance to access their data, so it's useless at that time.
- Not sure i see the point of passing "$oauth['oauth_token']" and "$oauth['oauth_token_secret']" to linkedin_account_inserted. Think $account is sufficient (tokens are in db, should they ever be needed anyway), but I might be missing something here ?
Can you try the attached patch before I commit ?
Comment #3
bellesmanieres commentedThis has been fixed quite a long ago, had forgot to close the issue !
Comment #5
Anonymous (not verified) commentedIt would be nice to have these hooks in the D7 version aswell.
Grts
TimLeytens