Needs review
Project:
PNG Fix
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Dec 2010 at 16:06 UTC
Updated:
5 Jul 2020 at 11:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
slashrsm commentedThis works for me. Just some minor modifications were needed to make it work on D7.
I've added packed version of jQuery pngFix lib and enabled user to choose between packed/normal version in administration pages.
Also added some minor modifications to pass Coder review.
Comment #2
mgiffordI just re-rolled the patch against git. Hoping this helps get out a d7 version of this module.
Comment #3
joeyabbs commentedsubscribing
Comment #4
joeyabbs commentedAlthough Drupal 7 uses jQuery 1.4 it should be considered to update the
jquery.pngFix.jsfile in order to support jQuery 1.5.x.As of jQuery 1.5 attribute selectors must be wrapped in quotes (they always should have but now jQuery is strict about it).
Therefore the following (Line #49) will no longer work:
jQuery(this).find("img[src$=.png]").each(function() {This must be updated to:
jQuery(this).find("img[src$='.png']").each(function() {(single quotes now wrap .png)Line #101 should also be updated to:
jQuery(this).find("input[src$='.png']").each(function() {I have tested these changes and jquery.pngFix.js now works for latest jQuery as well as continuing to work with older versions of jQuery.
Comment #5
dddbbb commentedsub
Comment #6
klonosSo far it works for me whether I use jQ 1.4.x or 1.5.x versions. The patch is a simple edit of the one in #2 to include the single quotes wrap as per #4 above.
@Rob Loach: would really appreciate it if you gave this a quick review at some point?
Comment #7
klonos...and her's the actual file ;)
Comment #8
klonosUpdate: ...just letting everyone here + anyone else interested know of the PNG Behave! project that already has a stable 7.x version available.