Is it happening? What needs to be done?

CommentFileSizeAuthor
#7 pngfix_d7_port_wrap_attrib_selectors_in_single_quotes-1003346-6.patch16.74 KBklonos
#2 upgrade2d7-1003346-2.patch16.73 KBmgifford
#1 pngfix.drupal_7_port_1003346_1.patch16.14 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Active » Needs review
FileSize
pngfix.drupal_7_port_1003346_1.patch16.14 KB

This works for me. Just some minor modifications were needed to make it work on D7.

I've added packed version of jQuery pngFix lib and enabled user to choose between packed/normal version in administration pages.

Also added some minor modifications to pass Coder review.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
upgrade2d7-1003346-2.patch16.73 KB

I just re-rolled the patch against git. Hoping this helps get out a d7 version of this module.

joeyabbs’s picture

joeyabbs CreditAttribution: joeyabbs commented

subscribing

joeyabbs’s picture

joeyabbs CreditAttribution: joeyabbs commented

Although Drupal 7 uses jQuery 1.4 it should be considered to update the jquery.pngFix.js file in order to support jQuery 1.5.x.

As of jQuery 1.5 attribute selectors must be wrapped in quotes (they always should have but now jQuery is strict about it).

Therefore the following (Line #49) will no longer work:
jQuery(this).find("img[src$=.png]").each(function() {
This must be updated to:
jQuery(this).find("img[src$='.png']").each(function() { (single quotes now wrap .png)

Line #101 should also be updated to:
jQuery(this).find("input[src$='.png']").each(function() {

I have tested these changes and jquery.pngFix.js now works for latest jQuery as well as continuing to work with older versions of jQuery.

dddbbb’s picture

dddbbb CreditAttribution: dddbbb commented

sub

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Drupal 7 port » Port PNG fix module to drupal 7
Issue tags: +D7 porting, +port to d7, +d7 ports

So far it works for me whether I use jQ 1.4.x or 1.5.x versions. The patch is a simple edit of the one in #2 to include the single quotes wrap as per #4 above.

@Rob Loach: would really appreciate it if you gave this a quick review at some point?

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
FileSize
pngfix_d7_port_wrap_attrib_selectors_in_single_quotes-1003346-6.patch16.74 KB

...and her's the actual file ;)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

Update: ...just letting everyone here + anyone else interested know of the PNG Behave! project that already has a stable 7.x version available.