This patch just changes mysql_ to db_ ina few places and uses a sequence for an auto increment id replacement. I was having trouble using case tracker with mysqli and this cleared it up.

CommentFileSizeAuthor
dbQueryPatch.txt2.22 KBmichaelfavia

Comments

morbus iff’s picture

michaelfavia: PLEASE make patches against HEAD, and not the current 4.7 build. 90% of your patch is irrelevant due to reworkings in HEAD, and the other 10% is just wrong ;) ... db_next_id(), under MySQL, expects a sequence in the sequences database table, which doesn't exist for "casetracker_comment_status" and never has. Thus, that change will actively break existing sids since it'd start over at 1. Also be aware that, until yesterday, Case Tracker publicly stated that it'd only work on MySQL. I removed that particular comment because most third party modules don't actually work on anything but MySQL, but don't actually state as much.

Finally, the original database design of casetracker_comment_status (and it's matching casetracker_comment) is bad, and I expect to be rewriting/goldplating it within a few weeks so that there will be no need for a $sid at all.

Thus, I'm marking "won't fix".

morbus iff’s picture

Status: Needs review » Closed (won't fix)