Attached patch removes the ampersand in the parameters from icl_content.wrapper.inc. Otherwise, warnings show up in the logs. I wasn't 100% sure about hook_node_prepare_translation() but included is the change for that as well.

CommentFileSizeAuthor
translation_management-node-hooks-by-value.patch.txt2.38 KBsillygwailo

Comments

Matroschker’s picture

Matroschker commented
Priority: Minor » Normal

Hello,

I got this error if activating "Content" (7.x-1.0-beta1) module from Translation Management:

Warning: Parameter 1 to icl_content_node_prepare() expected to be a reference, value given in module_invoke_all() (Zeile 817 von C:\xampp\htdocs\documentation\includes\module.inc).

Has anybody an idea? Currently we are in phase to setting up productive environment and we need the Translatio Management project.

I know this issue --> http://drupal.org/node/1010166 (I don't know if my error is same)
but the patch file is exactly the same as I have in my Drupal installation.

Thanks for help.
Mathias

mlecha’s picture

mlecha commented

subscribe

jan101’s picture

jan101 commented

subscribe

tebb’s picture

tebb commented

Following.

wienczny’s picture

wienczny commented

subscribe

anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
commented

Patch worked for me. Thanks

wienczny’s picture

wienczny commented
Status: Needs review » Reviewed & tested by the community

Patch worked for me, too. Thanks

jhorvat’s picture

jhorvat commented

Patch worked for Drupal 7.7 too. Thanks!

candelas’s picture

candelas commented

subscribe
thanks for the module! :)

edit: patch applied on drupal 7.7 and translation_management-7.x-1.x-dev
it works, thanks :)

tzanis’s picture

tzanis commented

hi, because iam new in drupal and i have the same problem how to install the above patch?

candelas’s picture

candelas commented

search in documentation.
they have a page on how to do it with git

astutonet’s picture

astutonet
Location Sao Paulo, SP
commented

In my case, the same patch returns this error:

Parse error: parse error, expecting `T_VARIABLE' in C:\wamp\www\mysite\sites\all\modules\translation_management\icl_content\icl_content.wrapper.inc on line 29

I'm using D 7.8 & the last dev version of Translation Management module.

Any ideas?

Tks.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Currently we're reimplementing this module from scratch in our codesprint:
http://drupalevents.ch/drupal/codesprint-2012

Thus all current bug reports and feature requests are dropped. Please recheck once the the sprint is completed.

kissaki’s picture

kissaki commented

What is the outcome of the codesprint? It seems nothing has come of it?

el_reverend’s picture

el_reverend commented
Status: Closed (won't fix) » Needs work

I would be interested in the outcome of either the code sprint or the advances made in the Translation Management module. Any suggestions

hgneng’s picture

hgneng commented

The patch works for Drupal 7.14. Why not merge it to dev?

@tzanis how to install patch (for Linux user):
$ cd sites/all/modules/translation_management/icl_content
$ wget http://drupal.org/files/issues/translation_management-node-hooks-by-valu...
$ cp icl_content.wrapper.inc icl_content.wrapper.inc.bak
$ patch -p1 icl_content.wrapper.inc -i translation_management-node-hooks-by-value.patch.txt

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

kissaki, thank you for asking...
You can be sure that amazing things came out when 25 people work a full week on such a topic.

The output is the NEW module TMGMT (Translation management tools) which is a full rewrite. This module was too broken and we didn't want to start cleaning it up and make something completely different out of it.
http://drupal.org/project/tmgmt

Note that next week we're having a second codesprint in our office for this module and things turn out to be amazing. All major translation providers are about to integrate in our module and we're kinda architectural driver for future. This is our german announcement for next week:
http://www.md-systems.ch/blog/2012-05/zweiter-sprint-fuer-translation-ma...

vb_swapnil’s picture

vb_swapnil commented

Thanks for the patch.

Patch applied on drupal 7.14 and translation_management-7.x-1.0-beta1 and its works fine, thanks :)
use following link to apply patch -http://drupal.org/patch/apply

hectorelgomez’s picture

hectorelgomez commented

Perfect, it works.

Thank you.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented
Status: Needs work » Closed (won't fix)

It sounds like from comment #17 that http://drupal.org/project/tmgmt is the way forward for doing translation management and this patch won't get applied to this project. I'm going to close this, with the note that my patch in the original seems to work for those that need it.