^

CommentFileSizeAuthor
cvs-minor.patch3.44 KBZen

Comments

AjK’s picture

OK, two points on this patch that Zen nor I could "get to the bottom of".

  1. When using fetch or wget I kept kept getting Windoze ^M EOL despite the fact I wasn't on Windoze when getting the patch
  2. I had to edit the $ Name: $ to remove the DRUPAL-4-7--2 tag in cvs.module

After doing that, patch applied. Once applied patch does what it's supposed to do on my test rig so it's a +1 for that.

AjK’s picture

Status: Needs review » Reviewed & tested by the community
dww’s picture

Status: Reviewed & tested by the community » Needs work

it's weird that for your own account, when you use the the edit tab and go to the CVS subtab, the title is now "my account", where as all the other subtabs use your user name. i think the check for $uid != $user->uid shouldn't be there, and we should just always drupal_set_title() there.

dww’s picture

also, i don't really like patches like this which change at least 3 different things, all under "minor fixes". ;) some of this can/should be back-ported to DRUPAL-4-7 (all the print vs. return stuff), but some is specific to 4-7--2 (e.g. the check_plain() on the motivation, since that's all moved around). there's 3 issues here:

1) print vs. return
2) the fubar title on the CVS subtab of the user edit tab
3) check_plain() in emails.

i'd prefer 3 issues/patches for this, so they can be committed cleanly/independently, and more easily backported as needed.

thanks,
-derek

Zen’s picture

Status: Needs work » Fixed

Fixed title issue and committed. Thanks guys.

Zen’s picture

Status: Fixed » Patch (to be ported)

and dutifully setting it to 'port'.

dww’s picture

Status: Patch (to be ported) » Fixed

i just backported the return vs. print crap to DRUPAL-4-7.

thanks for the cleanup, zen.
-derek

Anonymous’s picture

Status: Fixed » Closed (fixed)