Closed (fixed)
Project:
CVS integration
Version:
4.7.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
3 Dec 2006 at 22:33 UTC
Updated:
18 Dec 2006 at 01:15 UTC
^
| Comment | File | Size | Author |
|---|---|---|---|
| cvs-minor.patch | 3.44 KB | Zen |
Comments
Comment #1
AjK commentedOK, two points on this patch that Zen nor I could "get to the bottom of".
After doing that, patch applied. Once applied patch does what it's supposed to do on my test rig so it's a +1 for that.
Comment #2
AjK commentedComment #3
dwwit's weird that for your own account, when you use the the edit tab and go to the CVS subtab, the title is now "my account", where as all the other subtabs use your user name. i think the check for
$uid != $user->uidshouldn't be there, and we should just alwaysdrupal_set_title()there.Comment #4
dwwalso, i don't really like patches like this which change at least 3 different things, all under "minor fixes". ;) some of this can/should be back-ported to DRUPAL-4-7 (all the print vs. return stuff), but some is specific to 4-7--2 (e.g. the check_plain() on the motivation, since that's all moved around). there's 3 issues here:
1) print vs. return
2) the fubar title on the CVS subtab of the user edit tab
3) check_plain() in emails.
i'd prefer 3 issues/patches for this, so they can be committed cleanly/independently, and more easily backported as needed.
thanks,
-derek
Comment #5
Zen commentedFixed title issue and committed. Thanks guys.
Comment #6
Zen commentedand dutifully setting it to 'port'.
Comment #7
dwwi just backported the return vs. print crap to DRUPAL-4-7.
thanks for the cleanup, zen.
-derek
Comment #8
(not verified) commented