^

CommentFileSizeAuthor
cvs-reapply-2.patch7.18 KBZen

Comments

AjK’s picture

AjK commented
Status: Needs review » Reviewed & tested by the community
  • Same problem with the ^M line endings on the patch. Don't know what that's about as Zen seems sure they aren't actually there.

After editing off the ^M patch applied no problems. The new "re-apply" feature works a charm (previously, once "denied" you could not re-apply, you had to email the CVS admin list. This patch changes that and allows for re-application after a decline).

+1

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Needs work
  • REPLACE INTO is MySQL only. i know nothing else in cvs.module has been ported to pgsql yet, but i'd rather not add any more MySQL-isms if we can help it.
  • in cvs_application_page(), i'd prefer (for consistency with the rest of cvs.module and nearly all of core) to call that variable $output not $return.

also, don't forget to use "cvs diff -up" when generating your diffs (the -p tells you what function each part of the diff is in)...

thanks,
-derek

Zen’s picture

Zen commented
Status: Needs work » Patch (to be ported)

Fixed REPLACE query, variable name and committed. Set to port.

-up : I'm at the mercy of Eclipse on this one. I'll see what I can do..

Cheers!
-K

Zen’s picture

Zen commented

It probably doesn't help "the porter" that the patch currently attached to this issue is not the one that was committed.. This one on the other hand is.. :)

-K

dww’s picture

dww
we/he/they
commented
Status: Patch (to be ported) » Fixed

i'm confused. what's the status of this feature (i've lost track)? it looks like it's in both DRUPAL-4-7--2 and has been ported to 5.x in HEAD. shouldn't this be "fixed"? tentatively setting that way. please re-classify (with clarification) if it still needs to be ported somewhere. ;)

thanks,
-derek

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)