Allow using drupal themes to format HTML emails.

Improved patch, also combined with #1017776: Add transliteration support and #987174: Return-Path support

Updated patch fixes typo in transliteration support.

@jason.fisher -- Works fine in Hotmail, Yahoo, iPhone (with transliteration), and Andrioid. Also works fine in GMail and Thunderbird. Haven't tested Outlook but I don't expect problems.

Rerolled patch after the Great Git Migration.

Combines #1017776: Add transliteration support

Okay; rewrote so that libraries support is merely recommended, not required.

EDIT: Ignore this patch -- it has a typo.

Trying again...

You're probably not missing anything; I just made a typo again. Edit your htmlmail.module and on line 228 change $path to $emogrifier_path.

Fixing...

Once you do get it straight, check your admin/reports/status page -- it should tell whether the Emogrifier code was found. Then visit admin/config/system/htmlmail/settings and check the following boxes:

• Use site CSS
• Emogrifier
• Transliteration

I should probably make it so that the "Use site CSS" also checks "Emogrifier", and so that both options are disabled if Emogrifier is not available.

Improved and lightly tested. Patch looks bigger because the _htmlmail_emogrify() function was moved to an include file, but overall code size is actually reduced as compared with the last patch.

Better status report text.

weird... Maybe I can't use module_load_include() in an install hook?

(testing...)

Weird. Works for me...

Either drupal_get_path() is not available or you are missing the include file created by the last patch.

Try this one. If it doesn't work, check to make sure that that emogrifier/emogrifier.inc exists within the htmlmail module directory.

Attaching both a patch and a zipped copy of the patched module.

I'm running PHP 5.3.6

Try this one.

bah.

I honestly don't see how that error is possible. The include line immediately precedes the error you are reporting. Is it possible that PHP is running out of memory?

This should avoid the 500 errors but shouldn't work any differently. Somehow the module_load_include() line isn't working for you. Check permissions on the files and directories created by the patch?

Again, I can't imagine where that error is coming from. The only possible value of $paths in the code I submitted is NULL or an empty array.

(hmm...)

Well, in one place I assume that an uninitialized variable is empty(). I suppose that's a bad assumption, but in PHP it's *supposed* to be true.

Nevertheless, removing the assumption:

Looking again, I suppose it was converting NULL to array(0=>NULL) which would explain the problem.

Fixed?

Okay, I can duplicate that. I'm having no problems sending newsletters, but I'm getting the same error on a test message.

(troubleshooting...)

Errors the same way on simplenews "send test" and htmlmail "send test"... Curiouser and curiouser...

Okay, fixed, I think. At least, test messages now send on *my* site...

(another stupid typo, btw -- "emogrifer" --> "emogrifier")

Screenshots attached:

htmlmail_test_send.png

The admin/config/htmlmail/test screen I'm using.

htmlmail_test_received.png

What it looks like in Thunderbird with "Use site CSS" and "Emogrifier" turned on.

htmlmail_test_unstyled.png

What it looks like in a browser with no CSS at all.

So... compose something with html that would get styled by your theme CSS and test. Of course, it would be nice if the htmlmail test page would allow filter selection and wysiwyg editors like the node editing page, but that's a matter for another patch.

If you're still having problems,

Make sure that on admin/config/system/htmlmail you have the following (and only the following) checked:

• Use site CSS
• Emogrifier
• Transliteration

Visit admin/reports/status and make sure that "Emogrifer class" is "Available".

Compare "View Source" on your received email with "View Source" on your website pages.

htmlmail_test_unstyled.png

What it looks like in Thunderbird with "Use site CSS" and "Emogrifier" turned off.

Modified so that it only grabs styles with "media=all" or "media=screen" and ignores the rest.

Heavily modified and lightly tested.

• Allows selecting a drupal theme to format emails. This really lets your emails look just like a webpage. You can even create a special theme just for emails.
• Finishes the stub implementation of MailSystemInterface as described in Creating HTML formatted emails in Drupal 7.
• Allows full control over the mail_system variable: generates a select list of MailSystemInterface implementations for each installed module.
• Adds pathologic support for converting urls from relative (node/100) to absolute (http://example.com/node/100) format, so that linked resources are available to email recipients.

Discovered that having a blank value for $mail_system[$module] produces a run-time error. Re-coded to prevent that from happening.

Minor improvements:

• Strip Javascript, as it doesn't work properly in email clients, and may contribute to a false-positive spam classification.
• Corrected error in regex matching inline stylesheets.
• Removed redundant 'title' key from the hook_menu entry

More improvements:

• Delegated most of the filtering to filter.module where it belongs.
• Enable WYSIWYG editing in the template and test email forms.
• Create a "Plaintext emails only" profile field for users who prefer plaintext-only emails.
• Sends non-plaintext mails as multipart/alternative with both text-only and html parts.

Cleanup:

• For consistency replaced all "e-mail" with "email".
• Replaced "Implementation of" with "Implements" in comments.

Todo:

• Move emogrifier and transliteration to their own filter modules.
• Move UI for controlling variable_set('mail_system') to its own module.

EDIT: This patch relies on drupal_html_to_text which is currently broken by Patch #356074. A fix is posted in the same thread.

Fixed bug that was preventing the "Plaintext emails only" profile field from saving.

Created "Mail System" module for displaying the administrative UI for setting the mail_system variable.

Todo: Add AJAX to the form so a new module can be added without reloading the page.

Okay, split this whole thing off to a sandbox module:

http://drupal.org/sandbox/pillarsdotnet/1088646

Note that the title says "Theme Mail" and the instructions say "theme_mail" but really it's just a fork of HTMLMail.

Ah; nevermind. I see I now have commit access.

Committed to 7.x-1.x branch.