Closed (fixed)
Project:
Views Slideshow
Version:
6.x-2.3
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jan 2011 at 01:25 UTC
Updated:
2 Oct 2011 at 03:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
redndahead commentedLet me check to see if I understand. You have a link in a menu to the view. Let's say the path to the view is http://yoursite.com/myview You click that link and everything's awesome. But if you enter in the url into the address bar then it doesn't work
Do you have a site I can look at? There is no good reason why that would be. That is really strange.
Comment #2
mustanggb commentedhttp://dev2.snowdon.networkltd.co.uk/
Seems width and height are getting incorrectly set for
<div id="views_slideshow_cycle_teaser_section_slideshow-page_1">Comment #3
redndahead commentedok that is one of the weirdest things I have ever seen. So is the homepage set as the url http://dev2.snowdon.networkltd.co.uk/slideshow
Comment #4
mustanggb commentedIndeed, however it does it regardless of what the homepage is set to
Are you able to reproduce the issue?
Comment #5
redndahead commentedYep really very strange. What browser do you use? I just checked with IE9 and it works fine. When it wasn't working I was using chrome.
edit: and just checked Firefox 3.6 and it's working there too. Maybe Google Chrome only issue?
Comment #6
mustanggb commentedI have tested with the following:
- Chromium 10.0.627.0 (70364) fail
- Opera 10.63 (3516) fail
- Safari 5.0.3 (7533.19.4) fail
- Internet Explorer 8.0.7600.16385 fail
- Internet Explorer 9.0.7930.16406 pass
- Firefox 3.6.13 pass
- Firefox 4.0b6 pass
Comment #7
mustanggb commentedWhoops forgot to update status
EDIT:
Looking at
jquery.cycle.all.jsI see this:As we are passing slides in as div's (I think?) this magic code doesn't trigger
So the solution is to give width and height parameters to our img's, then the slide size can be calculated correctly
Comment #8
redndahead commentedHave you tried adding width and height attributes? Does it fix the issue?
Comment #9
mustanggb commentedI don't think it's an option yet
theme_image_style()relies on$variables['getsize'] = TRUEto do the legworkHowever it looks like
theme_image()has removed support for getsize?EDIT:
#1012416: Image styles don't add width/height attributes
Comment #10
redndahead commentedIn advanced options try adding slideResize set to 0
Also give me feedback on how easy/hard advanced options is to use.
Comment #11
redndahead commentedOne thing though is it seems like a browser issue when a link works fine, but going directly to the url doesn't.
Comment #12
redndahead commentedAlso try unchecking Fixed Height in action advanced options.
Comment #13
mustanggb commentedNope, still didn't work without #1012416: Image styles don't add width/height attributes
Hmm, it certainly does the job
Once you understand how it works within the module, i.e. dig around in
views_slideshow_cycle.jsfor a bitAnd that it's expecting javascript rather than php (not obvious from the help text)
Then it's usable for an intermediate level developer
I can see beginner developers or just regular admins being overwhelmed though
My suggestion would be for each dropdown option have different ways of selecting values
e.g. "backwards" is boolean so show only show "true" and "false" values
e.g. "requeueTimeout" is an integer so call it "Integer value" instead of "Advanced Option Value" and have a text input rather than a textarea
Also having to click "Update Advanced Option" as well as the usual "Update" is pretty user unfriendly and hard to remember
I can give you a small bug for this actually
Go into the Slideshow edit style settings, then click on the "Preview" button in the live preview area
Lots of "Update Advanced Option" and "Applied Options" will start appearing
Didn't work either
Comment #14
redndahead commentedThe advanced options was meant for intermediate to advanced users. But should hopefully be easy enough for anyone to use. I didn't want to use different fields for each one, because it makes it take a long time for the settings page to load. I was hoping that a text area would be able to handle any type of options necessary and wouldn't be too confusing. But I'm open to suggestions on how to create a happy medium.
Update advanced option was a necessary evil. There is only one actual box that contains all the settings. It is a hidden text area. I'm not sure of another way to allow the data to be entered and still be saved. Maybe a more explicit noticeable save thing.
Can you open a new issue for the bug? I'll look at it as soon as I get back to my main computer.
Thanks for testing this out.
Comment #15
redndahead commentedI will probably end up making this an option, but can you try this patch without a patched version of core and tell me if it fixes your issue?
Comment #16
mustanggb commentedIn principle this approach should also work
Will test once it goes green
Thanks for your dedication to this issue
Comment #17
redndahead commentedThere is no green for these patches ;)
Just need testing done.
Comment #18
mustanggb commentedI see, should be able to find some time tonight then
Comment #19
redndahead commentedThis patch was committed
Comment #21
Martin86 commentedGreet! First of all, I pretty bad use the grammatics and beg pardon. But I shall try greatly to explain the sense of the problem. My site http://xplc.ru On page Home is located slideshow. When visit URL (when decorous cookie) first slide do not show in get fat height. Than problem can be caused?
Comment #22
redndahead commentedPlease open a new issue. I understand that you have a hard time communicating in english, but can you please explain what your problem is again. I don't quite understand.