Reverse Geocode

Hello, and thank you for applying for a CVS account.

To apply for a CVS account and be co-maintainer, you need to create a support request in the project queue where you explicitily ask to be co-maintainer; only after the current maintainer accepts your offer you can apply for a CVS account.

I apologize if I didn't understand what you meant in your original post.

The archive containing the code needs to be attached in a comment here, and the motivation must include more than two sentences that are used to describe the module features, and a comparison with the existing solutions.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

I'm taking the liberty of updating this from a CVS application to a project application.

The project is already in HLopes' sandbox: Reverse Geocode, available via:
git clone http://git.drupal.org/sandbox/HLopes/1078432.git reverse_geocode

Holy shiver! This is almost vintage stuff here!

OK, let's start with a quick automatic review to get some points.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/reverse_geocode.module:
   +8: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +8: [normal] use a space between the closing parenthesis and the open bracket
   +11: [normal] Use an indent of 2 spaces, with no tabs
   +24: [minor] There should be no trailing spaces
   +26: [normal] missing space after comma
   +27: [normal] missing space after comma
   +28: [normal] missing space after comma
   +30: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
   +33: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +33: [normal] use a space between the closing parenthesis and the open bracket
   +37: [minor] There should be no trailing spaces
   +38: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +38: [normal] use a space between the closing parenthesis and the open bracket
   +46: [normal] use a space between the closing parenthesis and the open bracket
   +49: [normal] missing space after comma
   +50: [normal] Use an indent of 2 spaces, with no tabs
   +50: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +50: [normal] use a space between the closing parenthesis and the open bracket
   +50: [minor] There should be no trailing spaces
   +51: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +51: [normal] use a space between the closing parenthesis and the open bracket
   +52: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +53: [normal] the final ?> should be omitted from all code files
   +54: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +54: [normal] use a space between the closing parenthesis and the open bracket
  
  Status Messages:
   Coder found 1 projects, 1 files, 22 normal warnings, 3 minor warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically.
• @file doc block is missing in the module file, see http://drupal.org/node/1354#files .
• The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  

  ./reverse_geocode.module
  

• ./reverse_geocode.js: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

          // Uncomment the code block below to see all values that are returned from reverse_geocode.module.
  

• ./reverse_geocode.module: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

      // Uncomment below to get access to data returned from Google. Needs page refresh after clicking the button.
  

• ./reverse_geocode.module: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
  

  
  function reverse_geocode_perm() {
  --
  
  function reverse_geocode_init() {
  --
  
  function reverse_geocode_menu() {
  --
    
  function reverse_geocode_ajax($latlon) {
  --
  
  function reverse_geocode_form_alter(&$form, &$form_state, $form_id){
  

• There should be a space before and after operators like ==, ===, && and ||. See http://drupal.org/node/318#controlstruct
  

  reverse_geocode.js:27:    if(lat=="" || lon==""){
  reverse_geocode.js:46:        var full_address = (parsed["full_address"]==null) ? "" : parsed["full_address"];
  reverse_geocode.js:47:        var street_number= (parsed["street_number"]==null) ? "" : parsed["street_number"];
  reverse_geocode.js:48:        var route        = (parsed["route"]==null) ? "" : parsed["route"];
  reverse_geocode.js:49:        var sublocal     = (parsed["sublocality"]==null) ? "" : parsed["sublocality"];
  reverse_geocode.js:50:        var local        = (parsed["locality"]==null)? "" : parsed["locality"];
  reverse_geocode.js:51:        var admin_area_1 = (parsed["administrative_area_level_1"]==null) ? "" : parsed["administrative_area_level_1"];
  reverse_geocode.js:52:        var admin_area_2 = (parsed["administrative_area_level_2"]==null) ? "" : parsed["administrative_area_level_2"];
  reverse_geocode.js:53:        var admin_area_3 = (parsed["administrative_area_level_3"]==null) ? "" : ", " + parsed["administrative_area_level_3"];
  reverse_geocode.js:54:        var country      = (parsed["country"]==null) ? "" : parsed["country"];
  reverse_geocode.js:55:        var postal_code	 = (parsed["postal_code"]==null) ? "" : parsed["postal_code"];
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./reverse_geocode.js:     ASCII English text, with CRLF line terminators
  reverse_geocode.js
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  reverse_geocode.info:1:; $Id: reverse_geocode.info,v 1.1 2009/11/21 01:52:11 HLopes Exp $
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./reverse_geocode.js ./reverse_geocode.module
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

@HLopes has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Could we mark this application as postponed until you have the time to work on it?

@HLopes: Just mark this application 'needs review' when you are ready.

Hi HLopes!

We started to use, and - almost - completely rewrite your module. What about your time factor in the future?
Would you mind, if we take care for your module? Is it possible to "give" a sanbox project to someone else?

Thanks.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.