The batch importer currently gives no indication as whether a listed video has been imported or not. The following patch adds a function which does a simple select query to check each one and adds a 'status' column to the table with either indicates that the video is 'Unimported' or that the video has been imported and provides a link to the node.
Since this list can potentially be enormous, one thing that would be nice is to have each of these set to a default value and then checked individually by ajax, such as features does when checking if a feature is overridden or not.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1015112.4_ooyala_import_status.patch | 12.09 KB | deviantintegral |
| #3 | 1015112.2_ooyala_import_status.patch | 6.95 KB | deviantintegral |
| #1 | ooyala-import-status.patch | 4.58 KB | sirkitree |
| ooyala-imported.patch | 3.34 KB | sirkitree |
Comments
Comment #1
sirkitree commentedThis one is a bit more reliable.
Comment #2
quicksketchThis is a good UI improvement but may be a pretty serious performance problem. I'm not clear on if the video information has already been cached, but if it's not then it looks like this would do one HTTP request for each video in the list, which could cause a pretty significant slowdown when loading the page.
Updating title to reflect the feature, this just needs further review to ensure this isn't going to cause a problem.
Comment #3
deviantintegral commentedHere's an untested reroll that applies against master. I broke this down into separate commits, and also added a newline to deal with diff errors.
Comment #4
deviantintegral commentedThe video imported status is based on the local table, so outbound HTTP requests are not being used to determine the status.
However, I think it makes more sense to do one DB query instead of calling the function multiple times. Here's a patch that takes an array of keys instead of a single key. New commits include:
#1015112: Remove spaces from empty line.
#1015112: Fetch all video statuses in one SQL query.
#1015112: Only fetch video statuses if at least one key is passed in.
#1015112: Add documentation for the ooyala_get_status() function.
Comment #5
deviantintegral commentedI've committed the patch from #4.