If Input Format is set to PHP, code does not run, only displayed in the Quiz description field.

Comments

seanbfuller’s picture

seanbfuller commented

Good catch.

For the description, this should be a simple fix to quiz_view (change to line 447):

function quiz_view(&$node, $teaser = FALSE, $page = FALSE) {
  if (!$teaser && user_access('create quizzes')) {
    $node->body = theme('quiz_view', &$node, $teaser, $page);
  } 
  elseif(!$teaser && !user_access('create quizzes')) {
    $node->body = check_markup($node->body, $node->format) . theme('quiz_availability', $node);
  }
}

For the other fields, this may require an update to the database to make them all include their own format column. Along those lines, it would make sense to make them all revision enabled so they use the rid of the node instead of the nid as their primary join.

I'm pretty swamped right now, so I'm not sure if I'll be able to get a patch out.

goose2000’s picture

goose2000 commented

Hey - Thank you for looking at this, I'll try today and be your verify on this one (description only for now).

But it is nice assessment tool - hope you keep going with this one...

John

goose2000’s picture

goose2000 commented

Hmm, PHP seems to be returning this to the screen for description:

n/a

The other text fields already mentioned are doing this too, so they're all consistent now. 8).

John

goose2000’s picture

goose2000 commented

Ok, I got it working. Not sure if this good or bad? But I changed the line:

$node->body = check_markup($node->body, $node->format, $check = FALSE) . theme('quiz_availability', $node);

added ',$check = FALSE' parameter which defaults to TRUE if not specified. So I guess users can not view this 'filter' ? Not clear, but here is the API text:

----------------------------------------------------------

$check Whether to check the $format with filter_access() first. Defaults to TRUE. Note that this will check the permissions of the current user, so you should specify $check = FALSE when viewing other people's content. When showing content that is not (yet) stored in the database (eg. upon preview), set to TRUE so the user's permissions are checked.

gilcot’s picture

gilcot commented

Strange : i cannot reproduce the bug ...and Sean's correction was already in my side :/
About adding $check = FALSE, it's a good correction. i already suggest it in another issue related to multichoice module when i was working on it.

add1sun’s picture

add1sun commented
Status: Active » Closed (won't fix)

This is now quite different in the newer code and we are not supporting 4.7 so I'm closing this. Actually I don't see the description displayed anywhere now, but that is a separate issue from this.