spajax identifies the sortable elements inside of a container object (a div tag in this case) by an undefined ID ('title' should be 'node-sort-list')

There is still a javascript error, but this at least gets the sorting to work in IE.

CommentFileSizeAuthor
#6 nodeorder_fix.patch_1.txt767 byteswebavant
#5 nodeorder_fix.patch_0.txt769 byteswebavant
#4 nodeorder_fix.patch.txt785 byteswebavant

Comments

marcp’s picture

marcp commented

Could you please post a patch that fixes the problem? Thanks.

webavant’s picture

webavant commented

Well.. I haven't 'fixed' the bug entirely yet. I will look at it some more and then post a patch.

marcp’s picture

marcp commented

I reproduced the problem in IE 7 -- do you know if it does the same thing in IE 6? I've "upgraded" all my machines to IE 7 and can't test it in in IE 6 any more.

webavant’s picture

webavant commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community
StatusFileSize
new nodeorder_fix.patch.txt785 bytes

The issue is also apparent in IE6 as well as IE7. This patch eliminates the error in both IE and FF.

webavant’s picture

webavant commented
Status: Reviewed & tested by the community » Active
StatusFileSize
new nodeorder_fix.patch_0.txt769 bytes

Hmm... apparently I'm not supposed to set status to 'patch' on account of the CVS review team being overburdened with patches. Also, the previous one used both CR+LF, here is another with just LF.

webavant’s picture

webavant commented
Priority: Critical » Normal
Status: Active » Reviewed & tested by the community
StatusFileSize
new nodeorder_fix.patch_1.txt767 bytes

chx helped me decide that it easier to look at without escape characters... this should be the last patch on this issue

marcp’s picture

marcp commented

webavant,

thank you for the patch -- i will try it as soon as i get a chance. i was hoping to be able to keep the functionality of dragging the nodes only by their titles -- does this patch maintain that? also, is the quotes within quotes business something that is dictated by Spajax or Scriptaculous (or is it even possible to tell)?

marc

webavant’s picture

webavant commented

This patch does work in 'display nodes by title' mode, which I am quite fond of. The reason for the quotes within quotes is because it is ultimately being output by the Spajax module's function spajax_draggable_element to a string containing javascript. To address an object by ID in javascript you must use quotes. Perhaps the quotes should be patched into the Spajax module? I consider myself novice at javascript, but I'm somewhat certain that the quotes should always be there and cannot think of a reason why not, but someone please correct me if I'm wrong.

webavant’s picture

webavant commented

Also, just to further clarify, removing the quotes causes a javascript error in IE. Fine in FF.

marcp’s picture

marcp commented

So, looking at the Scriptaculous documentation, the handle option to Sortable.create is used to further drill down within the object to specify a class name for the draggable thing. In our case, I want just the title to be draggable. I think what's going on is that spajax_sortable_element() is putting out some either unnecessary or incorrect Javascript (I'm no Javascript whiz, either, by any stretch of the imagination).

I'm going to comment out the whole "if-elseif-else" block in spajax_sortable_element to see if it clears things up.

marcp’s picture

marcp commented

...well, as expected, commenting out the if-elseif-else block in spajax_sortable_element doesn't hurt things in Firefox. but it doesn't fix things in IE...

dreed47’s picture

dreed47 commented

Any resolution on this? Before the last patch was applied in this thread the drag and drop did not work in IE. After I applied the patch then it worked in IE BUT didn't work in FF.

Is there an earlier version of this module thatr works in both IE and FF? Does ANYONE have this module working fully in both browsers? If so, how did you do it?

pvanderspek’s picture

pvanderspek commented
Status: Reviewed & tested by the community » Closed (fixed)