I found this error in my logs:

Notice: Undefined variable: node in forum_access_menu_get_item_alter() (line 341 of /var/www/example.com/drupal-7.0/sites/all/modules/forum_access/forum_access.module)

It seems like it was generated from a normal authenticated user browsing around the forums.

Best regards,
Ao

Comments

Aonoa’s picture

Aonoa commented

I get this error with my admin user as well and I think it has to do with the edit comment permission/button. The button for editing comments are gone for Authenticated users, and it worked with previous versions of Forum Access (7.x-1.x-dev).

Best regards,
Ao

Aonoa’s picture

Aonoa commented

Reverting to forum access 7.x-1.x-dev (Jan 8th) removes the error and the comments edit button is available again for authenticated users.

Best regards,
Ao

Tilt_11’s picture

Tilt_11 commented

Same problem when upgrading to alpha3.

Hanscraft’s picture

Hanscraft commented

I've now tried both of the 7.x versions and I get that error message when logged out. When I click on any page other than home, that message pops up.

salvis’s picture

salvis
he/his
commented

I'm not sure I have enough information here.

"Any" page is generally not useful. If I had had this problem on all of my pages, I would have fixed it...

I need a full description of exactly one path (permissions, grants, DNA, etc.) that produces the issue.

Aonoa’s picture

Aonoa commented

For me, example.com/node/2, which is a forum topic with no permissions for anonymous users and with view and post permissions for authenticated users. Further, authenticated users are allowed to view, post and edit their own comments as well as creating, editing and deleting their own forum topics.

With forum access alpha3, authenticated users cannot edit their comments (the edit button isn't showing), and this error is displayed.

Is this sufficient information? I'm not sure what else I can say, my demo site only has it's original "General discussion" forum and I've posted a little in that. It was first discovered by a friend of mine on a site with a little more flesh in it, though.

Best regards,
Ao

PS! I'll repeat that the dev version of forum access from the 8th of January does not have this issue.

salvis’s picture

salvis
he/his
commented
Status: Active » Needs work

Ok, yes, that should give me enough, thanks. The previous -dev is toast. We're still at the alpha stage, I'm afraid, where things don't necessarily progress in a straight line. I'll try to come up with a test that identifies the issue and nail it down.

Aonoa’s picture

Aonoa commented

I have the old -dev if you want it, for comparison.

Best regards,
Ao

salvis’s picture

salvis
he/his
commented

I didn't mean I lost it, but it was broken in a number of interesting ways. It's amazing that it worked as well as it did, because it was trying to use number of Form API structures from D6 that aren't there in D7 anymore!

This makes it useless as a reference point, because too many things needed to be changed for ALPHA3 and can't be rolled back.

Aonoa’s picture

Aonoa commented

Aah, I see. In that case, good luck and thank you. :-)

Best regards,
Ao

salvis’s picture

salvis
he/his
commented

I fixed the notice in the -dev version (12h). I'm not sure whether it makes any difference in actual processing, but it shouldn't be there of course.

However, the notice is completely unrelated to whether you can edit a comment or not. The 'edit own comments' permission is now ignored by FA. This is by design. This permission is global across all forums and all content types. As such it's generally too broad to be useful if you run FA.

What was missing is a test that it actually is ignored as well as a hint that it is ignored (rather than just its absence in 'Permissions information'). I will add both of these.

Thanks for bringing up these points.

Hanscraft’s picture

Hanscraft commented

What I mean is that only authenticated users should be able to see the Forum tab, view the forum, post and edit their own content on the forum. In other words, unauthenticated users will have no idea there is even a forum on the page because there is no trace of it!

So, after I activated this module then went and clicked on "authenticated users only" (or whatever it is...), I then logged out of the website. So that put me on the home page. I then clicked on the other pages on the website that non-authenticated users can see (for example: about at mywebsite.com/about). The forum tab/page has disappeared from sight. However, the error message that started this thread shows up at the top of every page except the home page. Both Drupal 7 versions of this module had the same issue.

salvis’s picture

salvis
he/his
commented

@Hanscraft:

What I mean is that only authenticated users should be able to see the Forum tab, view the forum, post and edit their own content on the forum. In other words, unauthenticated users will have no idea there is even a forum on the page because there is no trace of it!

If that's how you've set it up, yes. This is one of many ways to configure FA. If you write "should" then I'm unclear about whether it's behaving correctly (except for the notice) or not. Please follow this pattern whenever you report an issue:
1. What did I do?
2. What did I expect to happen?
3. What happened instead.

Please install the current -dev snapshot and let us know whether you still see the notice (in the title of this issue) or not.

Aonoa’s picture

Aonoa commented

The current -dev snapshot seems to be working. I no longer receive the notice, and the edit button for authenticated users is displayed again.

Thank you. :-)

Best regards,
Ao

Kreativs’s picture

Kreativs commented

I still get that error line, I am using Forum Access 7.x-1.x-dev

Tried to uninstall the module , but its still there. When I run update , the updater recomends updating it to 7.x-1.0-alpha3. I press ok . When I check the modules list, still the 7.x-1.x-dev is present.

Basically I want the same as Salvis says. A forum that only is displayed for the authenticated users.

However it does work that way, but I get that error line wherever I go on the site.

(When I deactivate the module the error line dissapears.)

Aonoa’s picture

Aonoa commented

@tor:

It sounds to me like your Drupal site does not have ftp or some file transferring system in place, in that case you must download the new snapshot manually and replace it directly on the server. For instance with ssh.

Hope this helps.

Best regards,
Ao

Kreativs’s picture

Kreativs commented

Hi ! Thanks for your reply

At this point I am building the site on my computer , I have not published it online yet.
I am using Drupal 7 with the Acquia Drupal stack installer for Windows (DAMP) (Acquia Drupal 1.2.33)

I installed Forum Access by Module installer inside drupal 7 ( the new way directly inside drupal )
By copy and paste the link: http://ftp.drupal.org/files/projects/forum_access-7.x-1.x-dev.zip into the module installer. That is the module I have installed and it has installed sucessfully. Is that the correct module ?

As FA also requires the ACL module to be installed, I have installed the 7.x-1.0-beta2 version of ACL
Is that the correct version of ACL ?

Excuse me for my newbie knowledge about Drupal , but what is a snapshot ? Does that mean the latest version of the module ?

Thanks in advance
brgds
Tor

Aonoa’s picture

Aonoa commented

It is the correct link, but make sure it is the latest one from the 11th of January. That is a snapshot, a copy of the module code from a certain date. Much like a picture taken of someone on a certain date. You can use the check for updates feature on your site; http://localhost/node/2#overlay=admin/reports/updates. Do not install the alpha3 version of forum access, it is the reason I created this issue in the first place.

I am using the same version of the ACL module, and it works for me. I am using linux servers, and am not using the Acquia stack. Though, I do not think that should matter in this case.

Good luck.

Best regards,
Ao

Kreativs’s picture

Kreativs commented

Thanks for your explanation !

I did run the update as I posted before , but the updater found and instructed me to install the 7.x-1.0-alpha3

However by manually download the latest 7.x-1.x-dev zip file and unpack it and overwrite the old one in the sites/all/modules/forum_access/ folder did the trick ! :)

Thank you for your help !
brgds
Tor

salvis’s picture

salvis
he/his
commented
Status: Needs work » Fixed

Fixed in BETA4, should have marked this fixed a long time ago. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.