Provide upgrade path from poll.module [#102139]

Comment	File	Size	Author
#9	advpoll_convert_1.patch	5.1 KB	ChrisKennedy

#6	advpoll_convert_0.patch	5.12 KB	ChrisKennedy

#4	advpoll_convert.patch	4.17 KB	ChrisKennedy

Comment #1

anders.fajerson CreditAttribution: anders.fajerson commented 17 December 2006 at 09:46

This sounds like it could be developed as a seperate module, it could still be shipped with advpoll though.

Log in or register to post comments

Comment #2

ChrisKennedy CreditAttribution: ChrisKennedy commented 6 October 2007 at 17:46

This is an important feature to be implemented if we want to gain drupal "market share". Since Drupal 5 has been out for a long time we can probably not worry much about 4.7 polls that don't have votes. BUT I just now had an idea - if it's a 4.7 poll that doesn't have individual votes, we can just generate the right number of place-holder votes assigned to an anonymous user with IP of 0.0.0.0.

Design of advpoll-convert.module:
* Menu item in the admin/content
* Show a list of poll nodes ala admin/content/node
* Convert selected polls into the appropriate advpoll-binary node {max_choices:1, writeins: 0, runtime -> enddate, use_list: 0 } with all votes moved (or generated) into votingapi_vote, then regenerate cache.

Log in or register to post comments

Comment #3

anders.fajerson CreditAttribution: anders.fajerson commented 6 October 2007 at 18:07

So you want to make it possible to selectivly decide which polls to convert, not just a "click-convert-and-say-goodbuy-to-poll.module"-functionality?

Log in or register to post comments

Comment #4

ChrisKennedy CreditAttribution: ChrisKennedy commented 7 October 2007 at 17:09

Assigned:	Unassigned	» ChrisKennedy
Status:	Active	» Needs review

File	Size
advpoll_convert.patch	4.17 KB

Good point, no need to complicate the interface. Here's a patch that converts all poll.module polls via a single button. It doesn't take into account 4.7 polls yet.

Log in or register to post comments

Comment #5

anders.fajerson CreditAttribution: anders.fajerson commented 7 October 2007 at 17:25

Status:

Needs review

» Needs work

1. Votes added on the edit page ("Votes for choice N:) are not converted on my tests.
2. The body should probably be empty for new binary polls.
3. Some small UI suggestions:
- "X polls successfully converted." (I mean, this is cool!)
- Wrap the Warning text with a warning class to make it stand out and make a note about backuping the database first.
- "Node" is discourage for user facing text...

Log in or register to post comments

Comment #6

ChrisKennedy CreditAttribution: ChrisKennedy commented 7 October 2007 at 18:38

Status:

Needs work

» Needs review

File	Size
advpoll_convert_0.patch	5.12 KB

Yeah I'm not a big fan of poll.module's manual vote editing, but I guess we have to support it so that 4.7 polls can be converted. Here's an updated patch that should have everything fixed.

Log in or register to post comments

Comment #7

anders.fajerson CreditAttribution: anders.fajerson commented 7 October 2007 at 18:58

I see, that was the 4.7 thing. Tested and works. The only thing I would add is "messages warning" instead of "warning" as class. Oh, and maybe the mentioning of "node", but you decide about that.

Log in or register to post comments

Comment #8

anders.fajerson CreditAttribution: anders.fajerson commented 7 October 2007 at 19:01

I was going to mention that I'm not a fan of that either (the manual vote editing). Anyway, now we have a (very) unofficial way to manipulate polls, if it comes up again (I think it was in the issue queu some time ago).