Remove E_NOTICE in weblinks_filter [#1026858]

In the Devel module, php E_NOTICE warnings are now exposed, in an attempt to tighten up coding practices and improve readability and reliability of contrib modules - #970688: How to treat E_NOTICE in backtrace_error_handler()? has the details.

weblinks_filter_process() produces

notice: Undefined variable: search in weblinks_filter_process()
(line 104 of .../sites/all/modules/weblinks/contribs/weblinks_filter/weblinks_filter.module)
notice: Undefined variable: replace in weblinks_filter_process()
(line 104 of .../sites/all/modules/weblinks/contribs/weblinks_filter/weblinks_filter.module)

I have a patch which I will submit.

Jonathan

Comment	File	Size	Author
#2	e_notice code diff.jpg	94.25 KB	jonathan1055
#1	_1026858.weblinks_filter.remove_warning.patch	509 bytes	jonathan1055

Comments

Comment #1

jonathan1055 commented 14 January 2011 at 11:25

Status:

Active

» Needs review

Status	File	Size
new	_1026858.weblinks_filter.remove_warning.patch	509 bytes

The problem was attempting

return str_replace($search, $replace, $text);

when there was no match in the preg_match_all() call at the top of the function.

Here is a patch for your consideration, where the return is just the $text if no match was found.

Comment #2

jonathan1055 commented 30 April 2012 at 21:56

Version:

6.x-2.3

» 6.x-2.5

Status	File	Size
new	e_notice code diff.jpg	94.25 KB

Hi,
Any chance of someone reviewing this and then we can get it committed. Now that we have a good working latest release, it would be nice to avoid these e_notice warnings.
The patch above still applies ok, with a one-line offset. Attached is a view of the code changes - old on the left and new on the right.

Jonathan