In the core issue #522006: Conditional Styles in .info files, since drupal_add_css has it the proposed .info syntax agreeed upon was:

stylesheets-conditional[EXPRESSION][MEDIA][] = stylesheet.css

This means we should make two changes compared to the .info syntax used in 6.x-1.x.

  1. “stylesheets-conditional” instead of “conditional-stylesheets”
  2. EXPRESSION instead of CONDITION. Which means instead of “if lte IE 7”, we would use “lte IE 7”. That matches the expected expression used in the browsers option of drupal_add_css()<code> as used by <code>drupal_pre_render_conditional_comments

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Closed (fixed)

Fixed. http://drupal.org/cvs?commit=483436

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Closed (fixed) » Fixed
amanaplan’s picture

amanaplan commented
Component: Code » Documentation
Status: Fixed » Needs work

One little thing easy to miss...the information on the module's project page (http://drupal.org/project/conditional_styles) should be modified to reflect the change. Thanks!

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Component: Documentation » Code
Status: Needs work » Fixed

Crap. Thanks for noticing that, Christian!

The documentation is all correct (http://drupal.org/node/1031344), but the project page wasn't. :-p

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Er… I mean _now_ the project page docs are correct. double doh.

amanaplan’s picture

amanaplan commented

Great! Thanks a lot John.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 90e0658 on 8.x-1.x by JohnAlbin: 
    #1029696 by JohnAlbin: Update .info syntax to use expression expected by...