Closed (fixed)
Project:
Automated Logout
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jan 2011 at 08:56 UTC
Updated:
10 Jun 2014 at 13:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedI too am really interested in when there might be a stable D7 version available. I think this module is really good and really important.
Comment #2
mradcliffeHere are most of the fixes necessary. I will be able to see if it's working tomorrow fully, but this gets rid of the other 7.x-2.x bugs.
Comment #3
adaddinsaneTry this instead - I'm afraid your fix introduced a spelling mistake on the hook_permission() and there were DB calls that needed upgrading to D7.
Anyway, as I desperately needed it I fixed it.
My system doesn't produce good patches so here's a zip of the whole thing.
Changes - I've put it into the "Administration" package, extracted the settings function into its own file (need to keep the footprint down).
Personally I'd separate out the block timer into its own sub-module, then it could have dependencies and you wouldn't need to check every time you wanted to display the block.
Comment #4
d0t15t commentedFantastic! thanks, adaddinsane for the update...
Comment #5
primerg commentedHere is a patch for d7 installation errors taken from 7.x-2.x-dev. this patch added fixes for
#1034288: Fatal error: Call to undefined function db_fetch_object()
#960356: Activation error: Table autologout already exists.
Comment #6
wdouglascampbell commentedThe patch above didn't work for me so I made my own modifications to 6.x-2.4 to make it work on Drupal 7. In order for this to work, I also need to run the JSTimer 7.x-1.x-dev version. The other release has a bug in theme_jstimer that was causing errors.
I am posting here in case it helps someone else.
[EDIT] Ignore this, I somehow missed some of the other patches and I think they actually did some of the additional changes that I did and more some. Sorry :(
Comment #7
apoc1 commentedHey there, a minor bug I found it: if you're working with overlay, the overlay closes within the same time you entered in the configurationpage of autologout. Problem is, the timer doesn't restarts when you surf between several pages within overlaymode, it just closes after working a certain time.
Any resolutions?
Comment #8
wdouglascampbell commentedMy resolution for this was to turn off overlay. Probably not that helpful to you unfortunately and I haven't had time to look back at this in a while to suggestion a better resolution. Sorry :(
Comment #9
gregglesThere are some patches in git http://drupalcode.org/project/autologout.git/log/refs/heads/7.x-2.x
How do those compare to what's here?
@jrglasgow - it would be great if you could discuss your plans for the 7.x branch. Is the 7.x-2.x a port of 6.x-2.x (as my title indicates) or is it based on 6.x-4.x? When do you hope to have a stable release (even if it's beta or rc status). Thanks!
Comment #10
jrglasgow commented7.x-2.x is a direct port of 6.x-2.x. 6.x-3.x and 6.x-4.x are variations on the autologout idea completely written by other parties.
the patch in http://drupal.org/node/1034288#comment-5550950 contains the patch in comment 2.
#3 changes could be included is a patch against the current head would be included.
Since you requested it I just created a beta1 release.
Comment #11
gregglesGreat, so it sounds like the 7.x-2.x branch and the new stable release are working OK for folks so the original purpose of this issue is "fixed." However, as you note there is a new idea in comment #3 that's worth considering. I'm re-titling this issue to focus on that.
Thanks, jrglasgow!
Comment #12
jrglasgow commentedadded to "Administration" package
the settings were already in another file
Comment #13
gregglesGreat work - thanks again jrglasgow!