Upon saving configuration settings the message "The configuration options have been saved" is in-between the exiftran notification message alerts. This should be at the top of the message alerts.

Have to look at this - probably caused by the order that various drupal_set_message()s are called.

Comments

mwheinz’s picture

mwheinz commented
Status: Active » Fixed

The problem here is that the warning messages are output by acidfree_admin_settings() when the form is loaded, but the message "The configuration options have been saved." appears to be output by drupal core when the form is saved.

This seems to cause a problem where the warnings posted multiple times, which is what causes their position to move. For example, if you enter a correct path to the exiftran or jpegtran you will still see the warning one more time. Adding debug messages to acidfree_admin_settings it's obvious that drupal_get_form() is calling it twice for every time the form is displayed but I don't know why.

The fix is to guard the check of the exiftran and jpegtran variables to only occur when displaying a new form, not when validating it.

Fixed in dev as of this date.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.