Comments

ggause’s picture

The 7.0 port is pretty simple. If you make these changes it will work.

In require_login.info,
Change:
core = 6.x

To:
core = 7.x

In require_login.module,
Change:
drupal_goto('user', 'destination='. rawurlencode($_GET['q']));

To:
$options['destination'] = rawurlencode($_GET['q']);
drupal_goto('user', $options);

I'll figure out how patches are supposed to be posted and add in later in this thread.

ggause’s picture

StatusFileSize
new1.87 KB

Attached is a patch to upgrade the module to 7.x. Please note this patch needs to be applied to the cvs version. Checkout from cvs, then apply. If applying to the 6.x distribution, you will need to change the .info file manually as it will reject the changes (because the distro has extra comments added by drupal.org not found in cvs). Updating the .info is simply a matter of changing the core = 6.x to core = 7.x.

ggause’s picture

StatusFileSize
new1.86 KB

Bug fix for destination query parameter. Use this patch instead of previous patch.

waltf’s picture

Thank you very much! I'll try this.

TimelessDomain’s picture

#3 works! Thanks - This should be released already.

BernieCram’s picture

Hi ggause,

Just to feedback that I manually applied all the changes in p2 and it all seems to be working!

The patch didn't want to apply to the distributed 6.x-1.1 module after making the change to the .info from comment 2 but you can make the changes easily enough.

Anyone needing to get this running, read the content of patch2 and make those changes not the ones in comment one.

Thanks to you ggause

B

bofrost’s picture

Hi Guys,
thanks for pointing out the upgrade...

But the Issue is still open and the first question

Will u port this to drupal 7?

is still unanswered.

wbobeirne’s picture

StatusFileSize
new1.46 KB

This implementation busts Drush, see http://drupal.org/node/1230132 for more info.

Attaching a patch that fixes this.

Jeffrey C.’s picture

Status: Active » Needs review

With all these patches we need some reviews and testing.

Jeffrey C.’s picture

Priority: Normal » Major

Can someone please report how these patches work? I've obtained maintainership on this module and would like fix all these bugs as soon as possible.

Jeffrey C.’s picture

OK here's what I'll do: I'll create 7.x-1.x branch and apply #8 directly to 6.x-1.1 release.

dianacastillo’s picture

Status: Needs review » Needs work

Where is the 7.x-1.x branch?
I have it in zip format, how can I send it to someone to place on the module page?

Jeffrey C.’s picture

Please attach the package here. I'll review it then commit it. Most appreciated :).

dianacastillo’s picture

StatusFileSize
new7.04 KB

Hi , here it is attached

Jeffrey C.’s picture

Issue summary: View changes
Status: Needs work » Fixed

7.x-1.x branch has been created. Please file a separate issue for issues you encounter. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.