Will u port this to drupal 7?
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | require_login-7.x-1.1.zip | 7.04 KB | dianacastillo |
| #8 | d7-port-1032938-8.patch | 1.46 KB | wbobeirne |
| #3 | require_login_7.x_p2.patch | 1.86 KB | ggause |
| #2 | require_login_7.x.patch | 1.87 KB | ggause |
Will u port this to drupal 7?
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | require_login-7.x-1.1.zip | 7.04 KB | dianacastillo |
| #8 | d7-port-1032938-8.patch | 1.46 KB | wbobeirne |
| #3 | require_login_7.x_p2.patch | 1.86 KB | ggause |
| #2 | require_login_7.x.patch | 1.87 KB | ggause |
Comments
Comment #1
ggause commentedThe 7.0 port is pretty simple. If you make these changes it will work.
In require_login.info,
Change:
core = 6.x
To:
core = 7.x
In require_login.module,
Change:
drupal_goto('user', 'destination='. rawurlencode($_GET['q']));
To:
$options['destination'] = rawurlencode($_GET['q']);
drupal_goto('user', $options);
I'll figure out how patches are supposed to be posted and add in later in this thread.
Comment #2
ggause commentedAttached is a patch to upgrade the module to 7.x. Please note this patch needs to be applied to the cvs version. Checkout from cvs, then apply. If applying to the 6.x distribution, you will need to change the .info file manually as it will reject the changes (because the distro has extra comments added by drupal.org not found in cvs). Updating the .info is simply a matter of changing the core = 6.x to core = 7.x.
Comment #3
ggause commentedBug fix for destination query parameter. Use this patch instead of previous patch.
Comment #4
waltf commentedThank you very much! I'll try this.
Comment #5
TimelessDomain commented#3 works! Thanks - This should be released already.
Comment #6
BernieCram commentedHi ggause,
Just to feedback that I manually applied all the changes in p2 and it all seems to be working!
The patch didn't want to apply to the distributed 6.x-1.1 module after making the change to the .info from comment 2 but you can make the changes easily enough.
Anyone needing to get this running, read the content of patch2 and make those changes not the ones in comment one.
Thanks to you ggause
B
Comment #7
bofrost commentedHi Guys,
thanks for pointing out the upgrade...
But the Issue is still open and the first question
is still unanswered.
Comment #8
wbobeirne commentedThis implementation busts Drush, see http://drupal.org/node/1230132 for more info.
Attaching a patch that fixes this.
Comment #9
Jeffrey C. commentedWith all these patches we need some reviews and testing.
Comment #10
Jeffrey C. commentedCan someone please report how these patches work? I've obtained maintainership on this module and would like fix all these bugs as soon as possible.
Comment #11
Jeffrey C. commentedOK here's what I'll do: I'll create 7.x-1.x branch and apply #8 directly to 6.x-1.1 release.
Comment #12
dianacastillo commentedWhere is the 7.x-1.x branch?
I have it in zip format, how can I send it to someone to place on the module page?
Comment #13
Jeffrey C. commentedPlease attach the package here. I'll review it then commit it. Most appreciated :).
Comment #14
dianacastillo commentedHi , here it is attached
Comment #15
Jeffrey C. commented7.x-1.x branch has been created. Please file a separate issue for issues you encounter. Thank you.