Posted by Rob Loach on January 21, 2011 at 5:23pm
8 followers
| Project: | Favicon |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Rob Loach |
| Status: | postponed (maintainer needs more info) |
| Issue tags: | D7 porting, d7 ports, drupal 7 port, port to d7 |
Issue Summary
mikehoward put this together!
http://www.clove.com/sites/www.clove.com/files/downloads/favicon-d7.zip
Thanks Mike!!! We'll have to get this into the branch :-)
Comments
#1
Hmm, I couldn't get Mikes version to work, so I did a bit of investigation and came up with the attached version.
This is better because:
a) it works :)
b) it writes the favicon.ico file directly with an image/x-icon mime type rather than doing a browser redirect (so eliminating a server round trip, reducing page load time and probably working on more browsers).
c) works on buggy versions of IE (eg most of them!) that require (bizarrely) the mime type to be image/x-icon rather than the correct image/vnd.microsoft.icon
#2
ps: I had to comment out the following line from my .htaccess file to allow drupal to manage the favicon.ico file
RewriteCond %{REQUEST_URI} !=/favicon.ico
#3
I really like the SimpleTests! :-) ... Thanks a lot!
http://drupalcode.org/project/favicon.git/commit/666a898
#4
SimpleTests must have been Mike, because it wasn't me :)
#5
Let me know if 7.x-1.x-dev is good, because then I could get out a 7.x-1.0.
#6
looks OK to me (from a quick scan of the code - don't have any time to install and test for a few weeks - sorry).
only comment is that we've left a bit of debug code which could / should be removed on line 27
//print "file=".$file; die();#7
I've committed that change. http://drupalcode.org/project/favicon.git/commit/9262611 Thanks. I'll wait for some usage on 7.x-1.x-dev before making the 7.x-1.0 release. Thanks again!
Also, any reason why it asks for Shortcut module to be abled?
#8
no idea why it would ask for that. I don't have the Shortcut module on the site where Favicon is installed and it works fine - I don't remember being asked to install it either :/
#9
+1
#10
+1. Looks to be working ok for me.
#11
Works for me.
#12
Works just fine here too. Only minor thing is that in multilingual sites, all http://www.domain.net/[language]/favicon.ico URLs work perfectly ok (where language is whichever enabled language), but then it doesn't work for the plain http://www.domain.net/favicon.ico URL (without the language token). Trivial issue, but still...
#13
@Rob Loach, #7:
...The usage count is ~110 (and rising) as I'm writing this. Not that I care much for a "stable" release, dev seems to be working just fine ...well other than that minor issue I spotted in multilingual sites I mean.
#14
Up to 636 users for the 7.x version. Time for a 1.0 yet? Or is it being delayed for the multilingual issue?