Gotta do it :)

CommentFileSizeAuthor
#7 1036432-ab-1.patch631 bytesalanburke

Comments

jensimmons’s picture

jensimmons commented
Title: HTML5-ify node.tpl.php » HTML5ify node.tpl.php and field.tpl.php
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett

Sprint!

jensimmons’s picture

jensimmons commented

Need to consider ARIA roles for the node.tpl.php file.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

node.tpl.php: http://drupal.org/cvs?commit=487070

jensimmons’s picture

jensimmons commented
Status: Active » Needs review

big discussion on field, not changing anything about it right now.

alanburke’s picture

alanburke commented
StatusFileSize
new 1036432-ab-1.patch631 bytes

How about changing 

<div class="content">

to

<section class="content">
mason@thecodingdesigner.com’s picture

mason@thecodingdesigner.com commented

We talked about that in the room, but didn't come to a consensus to make it a SECTION. In the end we decided that if we couldn't agree that it might be best to leave it as a DIV. Some thought it should be a non-semantic container, others see your side.

I think it makes sense as a SECTION, but I'd like others to weigh in before changing it.

Anonymous’s picture

Anonymous (not verified) commented

I would like to see it as a section.

Also, we may want to consider using the time element and possibly the pubdate attribute to markup the published date. (I just happen to be reading up on the time element and saw this, so I thought I'd add it here).

http://dev.w3.org/html5/spec/Overview.html#the-time-element

mason@thecodingdesigner.com’s picture

mason@thecodingdesigner.com commented

We discussed the published date as well.

One thing we're trying to do is that since we're building this as a draft of what we want drupal core markup defaults to be we're avoiding preprocessing as much as possible. Anything that requires preprocessing we're pushing over to HTML5_tools module. That way these things can be enabled separately and applied to any theme.

The issue for that feature is here: http://drupal.org/node/1036784

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
jensimmons’s picture

jensimmons commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.