CVS edit link for niklas

Dear reviewers,

on a site I maintain we used textfields and number fields for ICQ and Skype contact information.
Textfields and numberfields integrate very well with Drupal 7 content types and the profile module, so I could easily attach those fields to user profiles.

However, both fields are do not exactly fit here. I could imagine two more possible things a more specific field type could do:
- Better validation
- Display of the users onlinestatus

Therefore I looked for any modules doing this and found none, but only some issues requesting something similar features, for example http://drupal.org/node/28089 .
The requested fields from the example issue doesn't fit in the profile module. So it has been set to "wont fix".

My custom module does the things I described. Since it provides only fields, it should integrate well with all existing modules that use the field api.
You can browse the code on Github (https://github.com/niklasf/imfield ) or download a tarball (https://github.com/niklasf/imfield/tarball/master ).

I want it to be a simple and secure module, because I am using it myself ;) I think others might want to use it, too. The module would benefit from being hosted on drupal.org. Documentation and issues would be way more accessible here.

Some details on the implementation:
The module almost only implements hook_field_*. Using those hooks it registers field types for each Skype and ICQ, a textfield widget and a plaintext and onlinestatus formatter.

The default theme function for the onlinestatus formatter works as follows. It is given a URL to an external status icon and displays it as an image.
Examples:
http://status.icq.com/online.gif?icq=385231655&img=5 (see http://www.icq.com/features/web/indicator.html )
http://mystatus.skype.com/smallicon/revoof?dontcache (see http://www.skype.com/intl/en-us/tell-a-friend/get-a-skype-button/ )
This means you have to trust status.icq.com and mystatus.skype.com if you use the onlinestatus display.

I am looking forward to getting feedback (and eventually CVS access) from you.

Best regards
Niklas

CommentFileSizeAuthor
#1 niklasf-imfield-68003a3 (2).tar_.gz2.01 KBNiklas Fiekas

Comments

Niklas Fiekas’s picture

Niklas Fiekas commented
Component: Miscellaneous » miscellaneous
StatusFileSize
new niklasf-imfield-68003a3 (2).tar_.gz2.01 KB

You must now go to http://drupal.org/node/1036632 and upload your intended contribution.

There you go.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: miscellaneous » new project application
Issue tags: +Module review

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

I will report here a little checklist:

  • The code needs to follow the coding standards; check in particular the format used for the control structures, and the name given to PHP variables, Drupal persistent variables, functions defined from the module.
  • Files available from third-party sites should not be included within the module/theme. This is particularly true for files that are not licensed under GPL License v2, but it is also true for files that are licensed under the same license used by Drupal.
  • The license file should not be included as well; the packaging script already include that file. In any cases, the code for modules/themes committed in drupal.org repository needs to be released under the same license used by Drupal; any compatible license is not allowed.
  • Check the code passes the Coder validation.

As per requirements, the motivation message should include also a comparison with the existing solutions.

Niklas Fiekas’s picture

Niklas Fiekas commented

Thank you.

There is currently no module that can display a users onlinestatus in Drupal 7 fields or CCK fields. The most similar module is http://drupal.org/project/onlinestatus. It could be ported to Drupal 7, but it lets Drupal check (from a http://onlinestatus.org/ server you have to host) the onlinestatus. IM Field just lets the user load an external image.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Postponed

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • If your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.