E_ALL Compliance: Fix PHP Notices in project.module

here's a re-roll for 5

this is definitely wrong:

@@ -708,7 +709,7 @@
         'href' => "project/issues/$project->nid",
       );
     }
-    if (module_invoke($module, 'project_sort_methods', 'group by date', $sort_method) && $date = _project_date($project->changed)) {
+    if (isset($module) && module_invoke($module, 'project_sort_methods', 'group by date', $sort_method) && $date = _project_date($project->changed)) {
       $projects .= "<h3>$date</h3>";
     }
     $project->class = ($class == 'even') ? 'odd': 'even';

what are you doing that's resulting in $module not being set? that doesn't look possible to me. if it is, then we need to fix elsewhere.

the above mentioned weirdness w/ $module has been fixed elsewhere, so rip that out and roll a new patch against the latest code.

this should do what we need. quick review would be nice.

Visually looks fine and light testing on a local site reveals no problems. Didn't actually turn on E_ALL yet, so it's possible there are other warnings lurking, but this is certainly an improvement. Thanks.

i turned on E_ALL and found a few more. we might as well get them all at once.

-    $version_form = drupal_get_form('project_release_version_filter_form', $version);
+    $version_form = drupal_get_form('project_release_version_filter_form');

something's wrong here. that form isn't built anywhere else that i can see, so what's the deal with function project_release_version_filter_form($version = NULL) if we're removing $version in the patch? do we need to get rid of $version as an arg, or correctly supply $version in function project_page_overview()?

reviewed, tested, committed to 5.x-1.x -- leaving to be ported if anybody cares to fix this in the older versions.