Visiting this page:
http://drupal.org/project/cvs/103482?nid=103482&page=5&nid=103482

results in a message:
"No CVS commit messages found." although the page is listed in the pager.

killes is to be blamed for the description ;-)

CommentFileSizeAuthor
#2 cvs_query.patch1.75 KBhunmonk

Comments

dww’s picture

dww
we/he/they
commented

yup, i just confirmed this is definitely still broken. i'm too tired to figure out the correct count query right now, but hopefully i'll be able to get to this soon.

hunmonk’s picture

hunmonk commented
Version: 4.7.x-1.1 » 6.x-1.x-dev
Assigned: Unassigned » hunmonk
Status: Active » Needs review
StatusFileSize
new cvs_query.patch1.75 KB

cid is not distinct in the result set, i think because there are multiple files per commit. attached patch adds a distinct operator to the query, which fixes the problem. tested and working perfectly on mysql. i ran the query on postgres and got no errors (and no results since i don't have a setup w/ cvs files in pg), so the query should be fine there as well.

also fixes improper precedence when the 'user' param is passed -- OR has to be enclosed in parentheses.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks!

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

fixed in HEAD, 4.7.x-1.x, 4.7.x-2.x

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)