The query run on module installation fails hard if there are any duplicate entries in {users}.mail (as we discovered the frustrating way while preparing this for use on d.o). That shouldn't happen, but uniqueness isn't enforced in the table schema, so it can. The attached patch updates the query to simply ignore duplicate entries using some idempotent ON DUPLICATE KEY UPDATE logic (which, I understand, is better than using IGNORE as it masks some problems).

CommentFileSizeAuthor
#6 1040192_multiple_email_duplicate_mail.patch334 byteshefox
#1 on-duplicate-key-update.patch295 bytessdboyer
multiple-email-failsafe.patch684 bytessdboyer

Comments

sdboyer’s picture

sdboyer commented
StatusFileSize
new on-duplicate-key-update.patch295 bytes

Yeah...attached the wrong patch. lol.

shawn dearmond’s picture

shawn dearmond commented
Status: Active » Fixed

Committed: http://drupal.org/cvs?commit=489056

Thanks!

hefox’s picture

hefox commented
Status: Fixed » Active

http://drupal.org/node/770068

On duplicate key update is mysql specific, not sure the solution for this issue though.

hefox’s picture

hefox commented

Ignore is also out (http://drupal.org/node/561978)

INSERT INTO multiple_email (uid, email, time_registered, confirmed) SELECT uid, mail, created, 1 FROM users WHERE uid != 0 AND mail != '' GROUP BY mail;

This seems to work, anyone see an issue?
I don't have an updated version of the code to patch against, will later assuming I don't forget.

cor3huis’s picture

cor3huis commented

Bumped, so @hefox you don't forget ;)

hefox’s picture

hefox commented
StatusFileSize
new 1040192_multiple_email_duplicate_mail.patch334 bytes

I forgot u.u

Here's the patch against a drush dl of dev version, untested.

It really should be tested against postgres! (I don't have a set up to test postgres).

shawn dearmond’s picture

shawn dearmond commented
Status: Active » Fixed

Committed: http://drupal.org/cvs?commit=496392

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.