When trying to install and/or uninstall the D7 dev version an error is thrown from the plugin_manager.install. The problem is these parts:

...
@mkdir(file_directory_path() .'/plugin_manager_extraction/');
@mkdir(file_directory_path() .'/plugin_manager_cache/');
...
plugin_manager_delete(file_directory_path() .'/plugin_manager_extraction/');
plugin_manager_delete(file_directory_path() .'/plugin_manager_cache/');
...

file_directory_path() was removed in D7 according to: http://drupal.org/update/modules/6/7#file_directory_path

They suggest using: variable_get('file_public_path', conf_path() . '/files') instead.

The attached patch should fix this.

CommentFileSizeAuthor
#2 file_directory_path-2.patch2.06 KBspan
file_directory_path.patch1.18 KBspan

Comments

span’s picture

span commented
Status: Needs review » Needs work

Sorry, this fails due to some other problems. Gonna make some changes.

span’s picture

span commented
StatusFileSize
new file_directory_path-2.patch2.06 KB

Ok, so here is a new patch. This patch also fixes a problem where the schema was being sent to mysql for installation twice. In D7 drupal_install_schema() and drupal_uninstall_schema() should not be called as this calling is handled by Drupal. The calling of these methods throws a "table already exists" error.

One thing that I still don't understand is why I am getting "Could not create directory..." for the themes and modules folders. It could be my local setup that is causing this. In D7 however, both the themes folder and modules folder are standard and do not have to be created by the user so perhaps those lines could be removed completely?

span’s picture

span commented
Status: Needs work » Needs review
DrewMathers’s picture

DrewMathers commented

@span,

Your patch worked for me. PM creating its directories without a problem.

span’s picture

span commented
Status: Needs review » Reviewed & tested by the community

Works for me to now, probably some local testing environment problems.

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the work.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.