CVS edit link for James Benison

Drupal 7 is ready to go but a lot of modules have not yet been migrated. This is a limiting factor at present in getting people to create new sites using drupal 7 rather than drupal 6. I have been building a site for a few weeks in d6 and thought that d7 would be better for both some of the existing functionality and with respect to the future. It utilizes a lot of views slideshow plugins that are not available in Drupal 7 though. I first attempted to migrate them to the D7 version of views slideshow. Views slideshow seems to have changed a lot in structure and I found that a port was not really possible. So I created a few modules for the sites I'm developing and thought that I could contribute them. I have contacted the maintainers of views slideshow as in the longer term collaboration might be a better approach. In the meantime this was the only possible solution. Many many people are waiting to use these plugins.

Comments

jamesbenison’s picture

Component: new project application » miscellaneous
Status: Postponed » Postponed (maintainer needs more info)
StatusFileSize
new5.69 KB
new7.06 KB
new21.07 KB
new3.68 KB

DO NOT DOWNLOAD ANY FILES FROM THIS PAGE. THESE ARE ALL NOW OBSOLETE.
See: http://drupal.org/sandbox/jamesbenison/1076606

Working examples of these modules can be seen at www.lunarclips.com
The cycle plugin: www.lunarclips.com/cycle-demo
Galleria: www.lunarclips.com/aino-galleria-drupal
ImageFlow: www.lunarclips.com/drupal-7-imageflow

These modules are only a couple days new. Still have to go over a lot of stuff and create readme files, but they seem to be working.

jamesbenison’s picture

Component: Miscellaneous » miscellaneous
Status: Postponed (maintainer needs more info) » Needs review
jamesbenison’s picture

Title: Cloud Carousel for Drupal 7 ready for testing » I now have a working Nivo-slider plugin for D7 too
Category: support » task
StatusFileSize
new13.98 KB
tregeagle’s picture

Title: James Benison [jamesbenison] » I now have a working Nivo-slider plugin for D7 too
Category: task » support

This is great James, only I cannot seem to get D7 to enable it. I've tried putting the unzipped directories in sites/all/modules/custom sites/all/modules/ sites/all/modules/views I checked the permissions, tried to see a loose wire in your code but my understanding is still pretty thin.
I cannot see the modules listed in /admin/modules and so I cannot enable them.

I'm probably missing something stupidly obvious.

jamesbenison’s picture

Okay. I'm a bit confused. Drupal should be able to find the .info files pretty much regardless of where you put them in your installation. They should all show up under the 'views' section in your module list. Have you checked out www.lunarclips.com/node/13? Permissions should not be an issue at all.

tregeagle’s picture

StatusFileSize
new34.48 KB

Well that's what I thought so I just tried installing your modules on one of my VPS accounts:

drupal-7.0/sites/all/modules/custom$ ls -la
total 28
drwxr-xr-x 7 user user 4096 2011-02-02 16:18 .
drwxr-xr-x 6 user user 4096 2011-02-02 20:51 ..
drwxr--r-- 2 user user 4096 2011-02-02 16:17 views_jqfx
drwxr--r-- 3 user user 4096 2011-02-02 16:17 views_jqfx_cycle
drwxr--r-- 5 user user 4096 2011-02-02 16:18 views_jqfx_galleria
drwxr--r-- 5 user user 4096 2011-02-02 16:18 views_jqfx_imageflow
drwxr--r-- 4 user user 4096 2011-02-02 16:17 views_jqfx_nivoslider

Everything looks right, but they don't show up in the Drupal 7 Modules install page. I can install other modules OK. I even went as far as to write my own test info file and that shows up.

jamesbenison’s picture

Wow. Just woke up and got your message. Off the top of my head I must say that I'm stumped. It's just a dot info file. I could sorta maybe understand if one of them wasn't showing up, but 5 invisible dot info files is baffling. They are working for me on the WAMP server in my laptop and on my dedicated server (CentOS 5.5, php 5.2.16).

I churned out all those modules in only a few days (and expected to have jcarousel done today too). I really need to take the time to go over the code for things like adherence to coding standards, documentation, fix a few things here and there. It's also a good excuse for me to install the virtual box on my laptop. Glancing at the code I see things that need to be addressed, but I don't see anything that should keep them from working, let alone make them invisible.

Get back to you in a bit.

jamesbenison’s picture

Now that I'm awake...you mentioned permissions and I thought you were talking about drupal user permissions. Is that the way the folder permissions were set when you uploaded the unzipped directories? They should be 755 . So should the subfolders.

jamesbenison’s picture

Fixed many issues regarding compliance with drupal coding standards. And these were compressed directly in the modules directory on the server hosting the examples. Folder permissions should not give you a problem.

jamesbenison’s picture

Title: I now have a working Nivo-slider plugin for D7 too » Most Recent jQfx Versions
StatusFileSize
new12.75 KB
new11.58 KB
new11.82 KB
new22.45 KB
new8.28 KB

These have some documentation now. And I'm pretty darn close regarding coding standards. Still have a lot of improvements that I would like to make though. It would be nice to get some people trying these so I can get feedback to help guide what needs to be done next (first).

And it would be helpful to have a CVS account to facilitate this (hint).

The current jCarousel module for Drupal has views support. It has problems with the form not displaying in views though. The version that I started working on got the form problems sorted out but I hadn't finished getting it to render. I'm going to see what I can do to help out with the regular jCarousel module port and try to fix their form issues. It's complicated the way they did their forms because they are using their own ajax callbacks, and I don't completely understand why. Ctools and views should be able to do that for them. I need that module working.

Let me know if you're still having trouble with enabling my modules.

Oh, and depending how the views slideshow things work out, these might just end up becoming the plugins for that project. Until they get their issues sorted 'views jqfx' is the only option for an api.

Opaque’s picture

Hello. I just tried installing this, and got it working.. But i somehow get a php error:

Notice: Undefined offset: 1 in template_preprocess_views_jqfx_nivoslider() (line 23 of /Users/benjamin/Sites/slidertest/sites/all/modules/views_jqfx_nivoslider/theme/views_jqfx_nivoslider.theme.inc).

Im bad at php, so could you help me solve this?

jamesbenison’s picture

That preprocess function will eventually need to be overhauled or replaced. To solve this just set the image field that is in your view as a link. Could be a link to anything. Preprocess function just need to have a url. Note that I'm still working on the link functionality for the Nivo Slider. Some things are not working yet.

jamesbenison’s picture

StatusFileSize
new15.51 KB

Updated Galleria module. Fixed a lot of stuff. Very powerful plugin.

The Galleria plugin does not come with the lightbox or the dots themes. I had a copy of the dots theme from an old Galleria release that I'm putting on my website. I also found a copy of the lightbox theme and will put that up as well. However, I haven't gotten the lightbox theme to work. Maybe somebody will figure it out before I get around to it.

Other issues to be aware of:
Thumb fit works fine, but every time I navigate back to the settings menu I find it unchecked. Needs to be checked again before resave.
Shows the four stock theme options even if they are not all installed. If you choose a theme that isn't in your plugin the Galleria won't work.
If a height option isn't set when using classic or dots the Galleria won't load.
Throws undefined index error notice if images do not have a link url.
Let me know if any other things pop up.

Examples: www.lunarclips.com/galleria-classic
www.lunarclips.com/galleria-dots
www.lunarclips.com/galleria-fullscreen

Opaque’s picture

Nice thanks for the quick reply. I look forward for the function to link the different slides to nodes.

jamesbenison’s picture

StatusFileSize
new12.57 KB

Nivo Slider link problem and undefined offset error fixed

jamesbenison’s picture

Title: Most Recent jQfx Versions » Nivo Slider for Drupal 7 is pretty much set.
StatusFileSize
new47.73 KB

I went ahead and 'finished' this since I got involved in fixing that link issue. I rewrote the preprocess function. Thumbnails are supported. I added a couple of theme options. Pretty much every Nivo Slider option is available. Everything seems to work. Code is to drupal standards.

As far as I can tell this module is pretty good to go now. Barring any surprises I think it's RC material.

jamesbenison’s picture

StatusFileSize
new12.36 KB

Updated Imageflow. All the bells and whistles should work.

jamesbenison’s picture

Not sure what the deal is with the CVS application. This page is turning into a cluster. The most recent versions of these will be on lunarclips.com. Not going to bother putting them up here.

jamesbenison’s picture

Not sure what the deal is with the CVS application. This page is turning into a cluster. The most recent versions of these will be on lunarclips.com. Not going to bother putting them up here.

tregeagle’s picture

Great work James thanks for all your work. I will test it out and let you know how I go.

jamesbenison’s picture

Title: Nivo Slider for Drupal 7 is pretty much set. » Cloud Carousel for Drupal 7 ready for testing
StatusFileSize
new35.11 KB

Title pretty much sums it up.

ParisLiakos’s picture

wow very good work!
maybe git solves your problems :)

Yucom’s picture

Title: I now have a working Nivo-slider plugin for D7 too » Cloud Carousel for Drupal 7 ready for testing
Category: task » support

Hi there,

I just installed your module (Nivo Slider) and it is working great, also after installing the patch for Chrome. I really like the way it works and would like to see some further development on it in the future. It would be great to have a feature where it is possible to give each slide/captation/image an extra link, so that it'll be possible to redirect users to different locations (maybe via CCK Link?). I know it is possible to add an overall link, but thats just a solution for the moment (for me).

Anyway, thanks for all your work and I hope to see more from you in the future. :)

Kind regards,

YuCom

Yucom’s picture

Okay,

just found a problem, and I dunno where it is coming from. The Slider shows up as intended in Chrome. But after refreshing the page the slider disappears (only the formating and the images, the navigation "dots" and the title is still visible and it is also running) . I have to flush the cache to get it back. It only happens after refreshing the page in the browser, but not if you visit the page by typing in the url/or by using a menu link.

Not quite sure where this is coming from, and also not if it is a problem with me or with drupal/nimo slider. As mentioned before I applied the patch to display images correct in Chrome.

Any idea? I am using Chrome 10.x (Beta).

Thanks in advance,

YuCom

jamesbenison’s picture

Does the same thing happen when viewing the demo page on my site in your browser?

Any chance you could send me an e-mail with a link to your page?

To be honest, pedrofaria put together a great nivoslider module for drupal 6 and I'm pretty sure he will have a great one for drupal 7. I made that module because I thought nivoslider was primarily a views slideshow plugin. I will be making upgrades to mine at some point (heck, probably within a few days), but it's not a major focus. Galleria is taking up a lot of my spare time.

Also, it is possible to link each images to their individual nodes instead of having an overall link. Views takes care of that part. Just chose link to content in your views image field.

Thanks

jamesbenison’s picture

Also, try turning off your css and javascript aggregation. The module should work fine with it on, but it can help when troubleshooting.

jamesbenison’s picture

Component: miscellaneous » new project application
Category: support » task

Most recent versions at http://www.lunarclips.com
All attachments here are obsolete

tregeagle’s picture

Thanks James, I've had this working nicely on my localhost this morning. I'll be interested to see how it develops. Hope you figure out the CVS/Git stuff with drupal.org

arianek’s picture

Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
rashad612’s picture

Guys,

The Cloud Carousel is already existed for Drupal as 3D Views Carousel :)
Any patches are welcome for Drupal 7 port.

avpaderno’s picture

Title: Cloud Carousel for Drupal 7 ready for testing » James Benison [jamesbenison]
Thien Chern’s picture

#24
Saw a temporary solution across the web.
If you "inspect element" slider in Chrome (after refresh), you'll notice the slider's actually collapsed with width: 0 and height: 0, so to get it not to collapse, modify the nivo-slider.css's class of:

.nivoSlider {
	position:relative;
	min-width: ?px; // to be the same width and height as your original banner
	min-height: ?px;
}

It might be Chrome's cache, but I have no idea how to really solve it other than doing the above =(

Thien Chern’s picture

#24
I made two blocks of nivo slider with different set of images, only then noticed the .class CSS changes made affect all sliders on site.
So I modify it's id by "inspect element" of the div container to check the id number (as per shown in the module of views_jqfx_nivoslider, under theme/views-jqfx-nivoslider.tpl.php)
Then include a CSS of the #id, e.g.:

#views-jqfx-nivoslider-images-? {
	min-height: ?px;
	min-width: ?px;
}
jamesbenison’s picture

Actually with Safari and Chrome Nivo Slider doesn't work due to this:
http://drupal.org/node/1012416#comment-3897286

If that isn't the culprit let me know please.

Also this project has a sandbox page here:
http://drupal.org/sandbox/jamesbenison/1076606

I'm hoping to get the discussions moved to the sandbox pages.

Thanks

Jim

Thien Chern’s picture

Component: miscellaneous » new project application
Status: Postponed (maintainer needs more info) » Postponed

I've applied the patch earlier, same as Yucom at #24.
But it doesn't seem to solve the browser refresh problem, image styles are still 0px.

Actually, with or without the patch, slider's image styles still load on the initial page load, problem occurs only on page refresh.

Thanks.

jamesbenison’s picture

Thanks for the heads up. I hate it when things don't work.

Does this problem occurs when viewing my site demo? My demo currently uses a page view.

Have you tried a content pane to see if that change anything?

The closest thing I have to Chrome beta 10 right now is Ubuntu Chromium. I stopped running linux on a v-box due to performance, and currently I have to switch drives to use windows.

Thank you once again for bringing this to my attention. I am super, super busy but I will try to take a closer look in the next 24 hours. I'm missing something, and I like I said I hate it when things don't work.

Jim

Thien Chern’s picture

Thank you actually for integrating this beautiful neat module.
Everything on your site demo is fine, even after a page refresh on Chrome beta 10.

I've checked every single element after I made a same duplicate as your demo, whether page view or block.
The worst thing now is I think it's my own (#24 Yucom didn't follow up so I've no idea of his/her status) Drupal problem/localhost thing or what not, since the page-refreshing issue will not go away.

tomtwigg’s picture

I am fairly new to Drupal and am working on a Drupal7 site that will utilize Nivo Slider. I thought a straightforward way to do it was to call the nivo scripts via the .info file and place the Nivo slideshow code in a block (I don't get why a module would be required for something that should be so simple). Problem is, there seems to be a conflict—by process of elimination I identified the drupal.js as the culprit—if I comment drupal.js out (using source) or temporarily remove it from misc/ the slideshow runs as expected. I'm not sure what critical functions drupal.js provides, but I'm sure removing it is a bad idea. Any ideas on this?
Thanks,
Tom

avpaderno’s picture

Project: Drupal.org CVS applications » Drupal.org security advisory coverage applications
Component: new project application » module
Status: Postponed » Needs review
greggles’s picture

Status: Needs review » Postponed

I think this is postponed until the code is posted to a sandbox.

But really, if these are all ports of modules to Drupal 7 then they belong in the issue queue for that module and, perhaps, as a request to take over maintenance if the modules are abandoned.

rv0’s picture

Status: Postponed » Needs review

@greggles, the code is in sandbox projects
The list is here:
http://drupal.org/user/772762

They aren't ports for existing D6 modules as far as I can see.

jthorson’s picture

Title: James Benison [jamesbenison] » Views jQFX

Updating title.

Sandbox link (posted in #34): http://drupal.org/sandbox/jamesbenison/1076606

jthorson’s picture

Priority: Normal » Critical

Updating priority according to the new project application priority guidelines. The application's priority should be set back to normal once a reviewer responds to your application and the application review process has continued.

jamesbenison’s picture

I'm getting a development environment set up on a new laptop and will update these modules in the next couple days.

Seemed to me like obstacles kept being put up regarding official project status. Kinda felt like a slap in the face. Didn't make sense for me to continue investing my time.

jthorson’s picture

Seemed to me like obstacles kept being put up regarding official project status. Kinda felt like a slap in the face. Didn't make sense for me to continue investing my time.

Sorry to hear you feel that way ... however, keep in mind that from February to June, this application sat idle due to it being in the obsolete CVS queue, and was not moved to the Project Applications queue as per the instructions referenced in comment #29. There was additional confusion caused by the fact that this issue contained multiple modules, while only one module is required for the review process (after which the submitter can publish the additional modules without mandatory review). Lastly, your sandbox link was buried in the middle of a support discussion which had nothing to do with this review process (and would have been better served in the sandbox project's issue queue instead of this application thread.)

You state you felt that roadblocks were being put up regarding official project status. The reality is that there are currently over 175 projects awaiting review (some of which date back to last summer), and another 200+ projects in some sort of 'partial review' state ... and a very small pool of dedicated reviewers actively trying to clear the backlog. We recognize that there are some definate issues with this process, and are diligently working to improve the situation - but in the meantime, we must work within the system we have; and as there was a number of issues with your application (as referenced in the first paragraph of this response, not in reference to the code itself!) it happened to fall though the cracks.

On the positive side, we've rectified those issues and got the application into the proper queue ... so while it's a long process, at least the application is back IN the process. Unfortunately, it now falls back to a waiting game, as response time in the queue is currently over 6 weeks for some projects.

In the meantime, if you'd like to elaborate on the obstacles you are referring to, or chip in a few reviews of your own to help clear the backlog, then feel free to drop by and provide your feedback in the "Code Review" group on g.d.o.

rv0’s picture

@jamesbenison
great news that you are picking this up again

tr’s picture

Priority: Critical » Normal
Status: Needs review » Postponed (maintainer needs more info)

I'm changing the status because it's not clear to me what's up for review here. Please clarify and set the status back to "needs review".

In #1 (4 March 2011) you said:

DO NOT DOWNLOAD ANY FILES FROM THIS PAGE. THESE ARE ALL NOW OBSOLETE.
See: http://drupal.org/sandbox/jamesbenison/1076606

Then you went on to attach zipped copies of modules in issues #1, #3, #9, #10, #13, #15, #16, #17, and #21.

I took this statement to mean you wanted us to ignore the sandbox and only look at the zipped modules. This was reinforced for me by the fact that you kept posting new zip files in response to issues raised in this thread, but you haven't updated the sandbox even once.

There has been a lot of activity in this thread, but the last commit in sandbox was on 28 Feb 2011. Does the sandbox reflect the current status of the code that you want reviewed for your project application? Is all of the feedback you've received above incorporated into the sandbox code?

jthorson’s picture

Status: Postponed (maintainer needs more info) » Needs review

March 4th was an update, telling folks to not pay attention to the zip files ... instead, look at the sandbox. Even though it's #1, the comment date comes after any of the referenced zipped files added later in the thread.

This used to be a CVS application, which used zip files for review ... after it was moved to a Git application, jamesbenison started using the sandbox as per the new guidelines.

Sandbox link (http://drupal.org/sandbox/jamesbenison/1076606) is posted in #32 and re-posted in #42. Application has already been set to postponed once due to someone missing the sandbox link ... let's not put james through that again!

jthorson’s picture

Priority: Normal » Critical

Updating priority.

Despite the number of comments in this thread (and due to a comedy of other errors/issues), the Views jQFX module still has never received an actual review.

jamesbenison’s picture

I'm working on updates now. Priorities are on the API and the Galleria plugin. Aino's Galleria is really pretty amazing. They have done a lot to it in the last few months. Looks like they might be adding video support utilizing the mediaelement.js player as well (which is stellar).

Once the API and Galleria module are set I'll put some time into the other plugins.

jamesbenison’s picture

Status: Needs review » Closed (duplicate)

I'm closing this out in favor of the Views jQFX Galleria module.

Please refer to: http://drupal.org/node/1107578

aeroweb340’s picture

Hi everyone,
I'm having an issue with Nivo slider using Drupal 7. The slider is misaligned and i'm trying to figure out why.
My images are all at the same size 900x284 and I'm using the default theme settings.
http://www.bridgenarbonne.com

Any idea?

Many thanks

avpaderno’s picture

Title: Views jQFX » [D7] Views jQFX
Priority: Critical » Normal
Issue summary: View changes
Related issues: +#1107578: [D7] Views jQFX: Galleria