[D7] Views jQFX: Galleria

We only need to review one of your modules. Please choose one of them and mark it as needs review. Thanks.

I know there's a metric ton of jQuery related modules. Why not integrate with http://drupal.org/project/jquery?

this in not "another jquery related module" and has no place in the jquery project imo

this is a (great) add on for views under drupal 7 and i'd love to see it become an official project as i'm using it a lot on new sites.

rv0:

James only needs to run one module through the application process, after which he will be granted the ability to promote the rest of the jQFX modules to full projects as well.

I'm marking this as closed(duplicate), in favor of the Views jQFX application already in the queue (located at http://drupal.org/node/1046018). If JamesBenison would prefer that this module be reviewed instead of the other, then please feel free to revert the status of this app back to 'needs review', and set the other application to closed "(won't fix)".

I understand that these applications have been open for a painfully long time ... we have been making a few changes lately to ensure that we can identify older applications (such as the original Views jQFX app), and are making them a priority for review purposes. Thanks in advance for your continued patience.

Just a note :
remove LICENSE.txt from the project.you dont need it, packaging script will add it automatically

ok i had time and checked your module further.
thats what i came up with:

• else {drupal_add_js($library_path . '/galleria/galleria.js');}
  

  should be

  else {
    drupal_add_js($library_path . '/galleria/galleria.js');
  }
  

• those pesky things are CVS leftovers and we dont need them now that we moved to git
  ; $Id$
• there are some trailing spaces, if you run it through coder's minor you can find them and fix them

Thats all.
including the LICENSE.txt removal should do the job.

When these issues are addressed set it back to needs review so i will RTBC it.
Thanks for your patience

i forgot a couple of things,
no big deal, i attached a patch that fixes 80 char limit for README.txt,
also added a space after type-casting according to drupal standars

setting to RTBC since they are minor things and you have been waiting that much

disregard my previous patch and use this instead, since i missed .info file.
addition to the previous patch:
files[] is only for OOP classes, so removed it

Here is another coding format patch, just some trailing whitespace.

Also, the populating of the settings array in views_jqfx_galleria.theme.inc is always ugly as I've experienced, but there a couple improvements to make.

The pattern
'carousel' => $options['carousel'] ? TRUE : FALSE,

is more readable and faster as
'carousel' => (bool) $options['carousel'],

Also, the entire chunk of

// Thumbnails is empty, numbers or boolean.
  if ($options['thumbnails'] == 'empty') {
    $settings['thumbnails'] = 'empty';
  }
  elseif ($options['thumbnails'] == 'numbers') {
    $settings['thumbnails'] = 'numbers';
  }
  else {
    $settings['thumbnails'] = $options['thumbnails'] ? TRUE : FALSE;
  }

Why couldn't this be

if (isset($options['thumbnails'])) {
  $settings['thumbnails'] = $options['thumbnails'];
}

Or if not that, at least make it

// Thumbnails is empty, numbers or boolean.
  if ($options['thumbnails'] == 'empty') {
    $settings['thumbnails'] = 'empty';
  }
  elseif ($options['thumbnails'] == 'numbers') {
    $settings['thumbnails'] = 'numbers';
  }
  else {
    $settings['thumbnails'] = (bool) $options['thumbnails'];
  }

That all said, the rest looks good, and you're ready to publish this module. I've granted you full project creation rights. Use this ability carefully!
Thanks for your patience.