Contents Mode is too useful to give up on entirely but depends on internals for various other data types making it excruciatingly hard to get working.

Proposed Replacement: Instead of directly accessing the original forms for video, image, et al, add class methods to the acidfree data types to support contents mode. Restrict the fields that can be updated to Acidfree's own options: parent album(s), possibly thumbnail.

The attached patch re-enables a dummy "mass update" mode that displays all the thumbnails and the bare bones of a form, but does not work.

CommentFileSizeAuthor
contents_mode.patch12.87 KBmwheinz

Comments

ringomassa’s picture

ringomassa commented

I was already working on this but the road you're taking seems much better. Will you be continuing the work or do you want me to take over? No use in both of us programming the same code.
I was thinking about separating the code into a .inc file, say album_content.inc, to reduce footprint and keep the code more clear.

mwheinz’s picture

mwheinz commented

Ringo,

Let me work on it for now; I'm pretty far along.

mwheinz’s picture

mwheinz commented

Committed a first pass of "Mass Update" to the dev tree. I couldn't work out how to update the taxonomy correctly, so albums are filtered out of the Mass Update page.

Still needs updates to CSS (to clean up the form layout) and javascript. (So that changing the title or body for an item causes that item to be selected.)

mwheinz’s picture

mwheinz commented

Ringo,

If you want to work on this - could you look at the form lay out? I have no head at all for design issues and other than being vaguely aware I don't want the delete button next to the update button, I don't have any ideas on making it work better. I broke up the form into separately themed sections so it should be pretty easy to add the right classes to acidfree.css.

On the subject of the delete button, if you want to look at something different, could you take a look at getting a confirmation dialog when deleting items? I tried, but I couldn't get it to work.

If you have any insights on how to move albums they would also be appreciated - the results of my attempts would leave the vocabulary out of sync with the album hierarchy. Taxonomy doesn't seem to actually have an API for moving a vocabulary term.

ringomassa’s picture

ringomassa commented

Should be possible to use the normal multiple node deletion confirmation system. I'll look into it later.
Right now i'm working on another issue:
http://drupal.org/node/1045822

mwheinz’s picture

mwheinz commented

Contents mode is almost finished. Need to update acidfree javascript to automatically check items when the user changes their title or body.

ringomassa’s picture

ringomassa commented

Still haven't found the way to implement the delete confirmation allthough i think i'm pretty close...
I would suggest using the same layout as /admin/content/node for the contents mode. This can be easily implemented by altering the form and would make the whole more consistent. All this would remove is the 'invert' option, however in clicks needed this is the same as selecting all and then deselecting some.
Don't have time to code now but it would look something like this:

-- Update options ---------------------------------------------------------------------------------
| Action:_________________________Destination:_________________________________|
| SELECTOR LIST_________________ALBUM LIST_____________[UPDATE]__________|
---------------------------------------------------------------------------------------------------------
[#] Select________________________Thumbnail________________Fields

mwheinz’s picture

mwheinz commented

I'll take a look at the layout.

mwheinz’s picture

mwheinz commented

Ringo,

I've updated the layout of contents mode to more closely follow the admin pages.

mwheinz’s picture

mwheinz commented
Status: Active » Needs work

Finished except for delete confirmation.

mwheinz’s picture

mwheinz commented
Status: Needs work » Active
mwheinz’s picture

mwheinz commented
Priority: Normal » Major

Okay - bumping this to major, since it's blocking the GA release.

mwheinz’s picture

mwheinz commented
Status: Active » Closed (fixed)

Delete confirmation is now working.