Need to make sure $form_state['values']['remove_flags'] exists before using it in a foreach in feeds_ui_mapping_form_submit() [#1048642]

I'm surprised no one else is reporting this, but I just installed Feeds, created a new Feed Importer using the Node Processor, went to add mappings and when I save a new mapping I get this error:

Notice: Undefined index: remove_flags in feeds_ui_mapping_form_submit() (line 612 of /home/gharvey/workspace/cmspros/trunk/www/sites/all/modules/feeds/feeds_ui/feeds_ui.admin.inc).
Warning: Invalid argument supplied for foreach() in feeds_ui_mapping_form_submit() (line 612 of /home/gharvey/workspace/cmspros/trunk/www/sites/all/modules/feeds/feeds_ui/feeds_ui.admin.inc).

Worse, no mapping is saved.

I've looked at the function, and I can see there's no check if $form_state['values']['remove_flags'] exists, so I guess it is expected to be there. Is there something not in the form array that *should* be there?

Marking 'critical' as right now this makes the module unusable for me and this is a blank Drupal 7 installation - there's hardly anything but Feeds installed.

Comment	File	Size	Author
#2	1048642-2-check_for_remove_flags_element.patch	764 bytes	greg.harvey

Comments

Comment #1

greg.harvey

English

Occitanie, France

commented 2 February 2011 at 13:33

Title:	Cannot save any mappings	» Need to make sure $form_state['values']['remove_flags'] exists before using it in a foreach in feeds_ui_mapping_form_submit()
Version:	7.x-2.0-alpha3	» 7.x-2.x-dev
Priority:	Critical	» Minor

Ok, tag this "total idiot". I didn't see the "add" button and thought "save" was how you add a mapping. So the real problem is there needs to be a check to ensure $form_state['values']['remove_flags'] exists before the foreach in the submit function.