quite a few project_issue related CSS "bugs" are showing up on http://scratch.drupal.org because i changed some classes from "project" to "project-issue", but didn't go through and change all of bluebeach's style.css to match. :( not sure if we should just revert the class names to the old, less accurate names, or change bluebeach.

related issues:
http://drupal.org/node/105042 -- "No colors on issues overview"
http://drupal.org/node/105044 -- "status summary styles"

Comments

webernet’s picture

This is most likely also the cause of the "Project" dropdown menu at http://scratch.drupal.org/project/issues being the width of the longest title rather than a predetermined max width as at http://drupal.org/project/issues.

This causes the search button to be hidden behind the right sidebar @1024x768.

webernet’s picture

Looks like its this line of the CSS:

.project .quick-search #edit-projects,
#edit-states,
#edit-project_goto {
  width:150px;
}

That line seems strange anyways since the .project portion only applies to the #edit-projects, explaining why the states dropdown isn't overly wide...

webchick’s picture

dww asked me to look into this @ IRC.

This should do it:

.project-issue tr.state_1.even { background:#f00; }
.project-issue tr.state_1.odd { background:#00f; }

caveats:

1. the class.subclass syntax is apparently broken in IE 6. :(
2. therefore, you probably actually want to do:

.project-issue tr.state_1, .project-issue tr.state_1.even { background:#f00; }
.project-issue tr.state_1.odd { background:#00f; }

This will make the "even" colour the default for all of the issues of that state in non-compliant browsers, and the .odd one would work for the rest.

webchick’s picture

Also, Jeff R says:

1. You should use "background-color", not "background"
2. You should use dashes rather than underscores in the class name.

dww’s picture

Title: issue-related div classes have changed -- bluebeach not matching » finish separation of project.css and project_issue.css
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new9.91 KB

fixing the title to be more accurate for the scope of the task at hand. ;) the fact that bluebeach doesn't match is a separate thing. really, most of that's just going to be fixed by removing crap from BB and letting project_issue.css do the right things.

anyway, i think this patch fixes all remaining problems. i've got a separate patch to steven to mostly take stuff out of BB. i'll install both on s.d.o momentarily so folks can see the results and search for any lingering problems.

thanks,
-derek

dww’s picture

StatusFileSize
new9.99 KB

got a few of the colors slightly wrong, and this version more consistently ensures that the active issues don't get the zebra stripes (seems a little wonky to only stripe those and not others).

dww’s picture

StatusFileSize
new9.89 KB

new patch that fixes conflicts from having committed http://drupal.org/node/106783.

dww’s picture

Status: Needs review » Fixed

committed to HEAD. i also committed the patch to bluebeach's style.css (after review from unconed). all is now installed on s.d.o out of cvs, and appears to be happy.

Anonymous’s picture

Status: Fixed » Closed (fixed)