quite a few project_issue related CSS "bugs" are showing up on http://scratch.drupal.org because i changed some classes from "project" to "project-issue", but didn't go through and change all of bluebeach's style.css to match. :( not sure if we should just revert the class names to the old, less accurate names, or change bluebeach.
related issues:
http://drupal.org/node/105042 -- "No colors on issues overview"
http://drupal.org/node/105044 -- "status summary styles"
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | project_issue_css_cleanup.patch_2.txt | 9.89 KB | dww |
| #6 | project_issue_css_cleanup.patch_1.txt | 9.99 KB | dww |
| #5 | project_issue_css_cleanup.patch.txt | 9.91 KB | dww |
Comments
Comment #1
webernet commentedThis is most likely also the cause of the "Project" dropdown menu at http://scratch.drupal.org/project/issues being the width of the longest title rather than a predetermined max width as at http://drupal.org/project/issues.
This causes the search button to be hidden behind the right sidebar @1024x768.
Comment #2
webernet commentedLooks like its this line of the CSS:
That line seems strange anyways since the .project portion only applies to the #edit-projects, explaining why the states dropdown isn't overly wide...
Comment #3
webchickdww asked me to look into this @ IRC.
This should do it:
caveats:
1. the class.subclass syntax is apparently broken in IE 6. :(
2. therefore, you probably actually want to do:
This will make the "even" colour the default for all of the issues of that state in non-compliant browsers, and the .odd one would work for the rest.
Comment #4
webchickAlso, Jeff R says:
1. You should use "background-color", not "background"
2. You should use dashes rather than underscores in the class name.
Comment #5
dwwfixing the title to be more accurate for the scope of the task at hand. ;) the fact that bluebeach doesn't match is a separate thing. really, most of that's just going to be fixed by removing crap from BB and letting project_issue.css do the right things.
anyway, i think this patch fixes all remaining problems. i've got a separate patch to steven to mostly take stuff out of BB. i'll install both on s.d.o momentarily so folks can see the results and search for any lingering problems.
thanks,
-derek
Comment #6
dwwgot a few of the colors slightly wrong, and this version more consistently ensures that the active issues don't get the zebra stripes (seems a little wonky to only stripe those and not others).
Comment #7
dwwnew patch that fixes conflicts from having committed http://drupal.org/node/106783.
Comment #8
dwwcommitted to HEAD. i also committed the patch to bluebeach's style.css (after review from unconed). all is now installed on s.d.o out of cvs, and appears to be happy.
Comment #9
(not verified) commented