Default Format (html) not applied in updated newsletter, advanced settings get cleared after updating node

Committed to CVS: http://drupal.org/cvs?commit=498858.

Thanks.

Is it possible that this bug (or a similar one) has made its way into 6.x-2.0-alpha2? I have the same problem as the original poster, but it appears to happen semi-randomly, and even occurs on newsletters I've already test-sent as HTML, which one assumes would have the setting saved.

@ambient - maybe this: http://drupal.org/node/1132404 ?

Thanks, but I had this problem before upgrading to Mime Mail 6.x-1.0-beta1, so it doesn't seem to be affected by that. Actually sending HTML properly doesn't seem affected, either before upgrading both modules, and after.

In 6.x-2.0-alpha2 the advanced settings are cleared when updating the node. 's_format' will get empty in the table 'simplenews_newsletters'.

When inserting a node, $node->simplenews is this:

[simplenews] => Array
(
    [advanced] => Array
        (
            [s_format] => html
            [priority] => 0
            [receipt] => 0
        )

    [s_status] => 0
    [test_address] => test@example.com
)

When updating a node, $node->simplenews is this:

[simplenews] => Array
(
    [nid] => 53
    [vid] => 54
    [tid] => 7
    [s_status] => 0
    [s_format] => html
    [priority] => 0
    [receipt] => 0
    [sent_subscriber_count] => 0
)

The function simplenews_newsletter_update() expects the advanced settings to be in the 'advanced'-array, but this array doesn't exists when the node gets updated, resulting in an empty 's_format' value.

Hi,

I have prepared a patch, which should hopefully fix this issue. It basically reformats flat array to array with "advanced" sub array. Please review :)

Subscribing

Duplicated by me with
#1210446: Newsletter by default plaintext, even if settings define html

Patch #9 works for me

#9 works for me, too. Thanks harijari.

Ok, it seems good. Before I commit it, shouldn't we call that on the node_load too, to have the same structure everywhere ?

If we change structure of simplenews array at node load, there will be more more changes required.

In fact, every place, where code access simplenews[one of advanced properties] value, will be broken.

Currently the system has a flattening function for exactly this case.
While for D7 i expect we should reimplement this completely, i strongly vote for an absolute minimum solution. Changing more will possibly break everything that is based on simplenews and does extend the module.

Tests needed...
Someone around to write tests about this topic?

Patch in #9 committed on 6.x-2.x-dev for now. We really need to work on a test suite.

This fix did not work for me: Still, the plain format is always selected.

Make sure to use the latest development version (6.x-2.x-dev).

Unfortunately it's still broken in the latest stable version (6.x-2.0-alpha2).