Performance: don't call drupal_get_path_alias() twice!

i wonder why you are checking for "/" on the end of an URL... it is is "not possible" to add a alias with a slash on the end. if someone do, it will not work everytime... i've done this mistake in past, and learned drupal isn't working well if a slash is attached to the URL... while this creates incompatible URLs in Microsoft IIS (tested again some minutes ago). it will crash the page while it ends with an URL http://localhost/drupal/index.php?q=example/ and as you can see you get a slash in an URL param, what is wrong!

So you should mark request for such a feature as "won't fix" or "by design".

I know this works with clean URL, but this is not a way how you should name URLs in Drupal. It breaks compatibility and therefor this is not correct. I think this will end in Apache with a URL param including a slash, too - and as i said - this is wrong... it more something like a small wonder, that it works... i think.

You may better use mod_rewrite or something like this in such a case, not tested... but implementing such a feature in a module is wrong from drupal side.

And what will you do if i'd ask you - for some other stupid people - for .html and htm extension and so on? will you implement this too? I think - if a URL is correct, it is - if not - it is not. Building this inside a module makes no sense. If I know my website and i'm implementing a simple mod_rewrite rule in my .htaccess. for e.h. if a slash is on the end of my URL, remove this and redirect to the same node without a slash - this is - highest performance you can get and do not require to add additional senseless DB request.

What you do is somewhat different as i have seen:

1. do a alias lookup to node/12345 to get "test/example"
2. alias not found and do not exist for this url - this can really happen - if there is no alias for every node
3. we haven't found an alias, we do another request, maybe there is a chance to fine a url with a slash (*maybe*)
4. another time - nothing will be found, while i have clean drupal urls and don't name my URLs internally with slashes on the end.
5. so there happen 2 alias table request without any result.

Correct?

About the IN () statement i think same... Drupal 6 may do the trick as i have seen...

another idea is - if you don't like mod_rewrite - remove the slash of an incoming URL via regex containing a slash and redirect to non slash URL btw. do the lookup with non slashes. This is possible, while you know your site url's are build technically correct without slashes on the end.

Let me reopen this issue, please. Have a look to this drupal core translation... it will tell you - you should never add slashes to the end of a drupal URL. Therefor the module should remove every trailing slash if coming in and do a lookup then. nothing else... and no double checking as today.

#: modules/path/path.module:192
msgid "Specify an alternative path by which this data can be accessed. For example, type \"about\" when writing an about page. Use a relative path and don't add a trailing slash or the URL alias won't work."