It's only a problem for people using the module jquery_update-6.x-2.0-alpha1 (http://drupal.org/project/jquery_update).
jquery_update-6.x-2.0-alpha1 updates Drupal to jquery 1.3.2 (required for modules like Modal Frame API) and in the process replaces some more Drupal core javascript files (compared to previous jquery_update versions), in particular the file tabledrag.js.
In outline_designer/scripts/script.js, Drupal.theme.tableDragChangedWarning is redefined to suppress the default warning message and returns a white space.
Unfortunately, in tabledrag.js, there's a call to this function which expects to find "something" when calling Drupal.theme.tableDragChangedWarning and when it doesn't, it throws an error and you can't drop the row you're dragging.
To avoid this problem, I've created a patch where Drupal.theme.tableDragChangedWarning returns an empty div rather than nothing and that solves the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| od_jquery_update_6.x-2.x.patch | 350 bytes | tlaurent |
Comments
Comment #1
btopro commentedexcellent. for those without this patch when the "can't drop" occurs if you click after moving it to the new location it should drop. Thanks for finding the root of this issue though as I could never figure out why that happened since it was so random.
Comment #2
btopro commentedWorks in my local build, good catch, weird that it fixes that issue since it's such a minor change :) I'll commit this on 1.3 when I get to it
Comment #3
tlaurent commentedyes, I agree, I'd have never suspected this bit to be the problem... actually, it took me quite a while to find it !
The problem is that in tabledrag.js, there's an "insertAfter" applied to whatever Drupal.theme('tableDragChangedWarning') returns. And unfortunately " " is not a valid expression to apply "insertAfter" on, you need to give any kind of HTML markings he can "feed" on.
Anyway, I'm very happy I found it, because my users where really not happy with having to "click to drop" (sometimes it was not even working at all for whatever reason).
I forgot to mention in my original post that I tested successfully the patch with jquery_update-6.x-1.1, jquery_update-6.x-2.0-alpha1 and with jquery_update disabled (and uninstalled).
Comment #4
btopro commentedGreat work, it's in my local stack and it's slated to be added to 1.3. Thanks!
Comment #5
btopro commentedComment #6
btopro commentedimplemented in 1.3 release
Comment #7
btopro commentedThis is fixed for the entire outline but when drilling down to just a part of the outline via outline_child_pages this problem still exists (at random). It's annoying and hopefully we can hunt it down fully in future releases. As it doesn't prevent you from using the module (and jquery_update is always fringy as is) I'm marking this as fixed still and if people take issue with it in Outline Child Pages they can create a new issue just for that as the original issue described is fixed.
Comment #8
btopro commented