project release link at node/add is a 404

i tried *very* hard for #1, and various drupal menu limitations, hook_access() behavior, and other woes made it impossible to get it right. :(

#2 is fairly reasonable in the short term.

but #3 would be even better: add another page to the N-page form. if you don't know the project, present page #0 to just select that. if you already know the project, skip to page #1 for the "start" of the release add wizard. very similar to creating a new issue.

/me waits for FAPI multi-step stuff to get more functional. ;)

As I wrote in (duplicate) http://drupal.org/node/199182 :

"Inspired and emboldened by what I learned over at http://drupal.org/node/199138 removing the evil multipage form for project_issues, we should do the same thing for release nodes.

Instead of converting the release node form into a true multipage form, all we need to do is stick a simple form directly at node/add/project-release with a project selector (restricted to the projects the current user has permission to create release nodes for), and then redirect to the full URL."

The code looks good to me and the functionality works well. I checked this using test users with different permissions and only got redirected to the add a release page when I had the appropriate permissions.

XSS on content type name:

+      'title' => t('Submit !name', array('!name' => $types['project_release']->name)),

Not *really* a big deal, but it's potential priv escalation and we don't do that. ;) You want '@' not '!' to be safe.

Committed to HEAD for 5.x-1.x.