Filedrop

Yes, I'd like to add techninja as a co-maintainer on our current and future modules.

rubber stamp++

He seems to know stuff about Drupal and development. He speaks with authority about many front-end type things.

Yeah, let's get this guy an account, please. He knows what he's doing.

It would be useful if he was given [vcs] access so that can add him as co maintainer, etc. (Shouldn't we be mentioning what projects... ?)

Never trust a ninja!
No, wait, I mean James is a great guy with good stuff to contribute.

I'm surprised James didn't already have an account. He's a talented Drupal developer with a lot of creativity. I'll look forward to his D.O. contributions!

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

• If your application has been "needs work" (or "postponed (maintainer needs more info)"), your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
• if the status of this application is a different one, it will be changed to "postponed"; you will be able to reopen it by following the instructions in the above link.

Better title. I did a quick look and the module looks sane, but I didn't do a full review. Thanks for sticking with it!

FYI: You don't need the Project Create permission to be added as a co-maintainer. Checking out the module...

You should create sandboxes for those projects. Do you plan on maintaining them?

* do not provide "version" in the info file, see http://drupal.org/node/231036
* sometimes you comment "Implements hook_xxx()", sometimes "Implementation of hook_xxx()". Please be consistent ("Implements hook_xxx()" is the new standard).
* filedrop_user_upload_form_validate() is not a hook implementation!
* same for filedrop_user_upload_form_submit()
* doc block on _filedrop_is_active_node_type(): use 2 space indentation on the next line after @param, as everywhere else
* have you run coder on your module? http://drupal.org/project/coder

You need to remove the version string from the file. Drupal.org will add this for you.

Thanks.

A few more items:

1. Unset any variables which are local to your module in your hook_uninstall routine
2. Can this be converted to a configurable admin setting?
   define('FILEDROP_NODE_ALLOWED_FILE_TYPES', 'jpg jpeg gif png txt doc xls pdf ppt pps odt ods odp zip rar tar gz');
3. Inconsistent spacing in if (condition) ? expression: expression; statements (space before the colon)
4. Suggest renaming filedrop_private_add_htacess to filedrop_private_add_htaccess.

Okay ... I'll stop nitpicking. :) Code looks clean and well documented. #1 is the only showstopper I spotted during a quick scan, though I probably don't have the experience to really analyze the file storage/access component.

Well done ... I look forward to seeing this in contrib!

Thanks for your contribution, techninja! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

Excellent timing. He's coming in to the office today. Can do a proper toast. ;)